Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blueprints): add possibility enable/disable default brand #11738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DrummyFloyd
Copy link

@DrummyFloyd DrummyFloyd commented Oct 19, 2024

Details

Because ovveriding default brand is bit painful with docker/kubernetes

=> mount entpy file to replace default-brand.yaml

can we instead add a env value like this,
will not breaking existing due to default fallback, but can be easily un defaulted what do you thiink ?
image

NB: this approch is IaC friendly


Checklist

None of them has been made du the minor change
not applicable i guess

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable
NB: will be done if accepted

  • The documentation has been updated
  • The documentation has been formatted (make website)

@DrummyFloyd DrummyFloyd requested a review from a team as a code owner October 19, 2024 13:47
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 32bd1e3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6713b8846b5e6e0009890f5d

Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 32bd1e3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6713b88465baf600088764db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant