providers/scim: fix scim sync (#11165)

[kpodp0ra]

Issue

Closes #11165

During SCIM synchronization, server can throw ObjectExistsSyncException to mark that one of the N objects are already synchronized. Authentik doesn't handle this error properly and crashes instead of displaying a simple warning.

Details

SCIM can throw these errors:

authentik/authentik/providers/scim/clients/base.py

Lines 72 to 77 in eac3e88

	if response.status_code == HttpResponseNotFound.status_code:
	raise NotFoundSyncException(response)
	if response.status_code in [HTTP_TOO_MANY_REQUESTS, HTTP_SERVICE_UNAVAILABLE]:
	raise TransientSyncException()
	if response.status_code == HTTP_CONFLICT:
	raise ObjectExistsSyncException(response)

But only BadRequestSyncException and TransientSyncException are caught and handled properly:

authentik/authentik/lib/sync/outgoing/tasks.py

Line 135 in eac3e88

except BadRequestSyncException as exc:

authentik/authentik/lib/sync/outgoing/tasks.py

Line 158 in eac3e88

except TransientSyncException as exc:

NotFoundSyncException and ObjectExistsSyncException are unhandled.

Solution

I've come up with two solutions:

1. Add two another except cases: 'except NotFoundSyncException as exc: ' and 'except ObjectExistsSyncException as exc: ' to authentik/lib/sync/outgoing/tasks.py
2. Subclass these two unhandled exceptions to already-handled BadRequestSyncException

In this PR I've chosen the second option and looked up the code to make sure that this will create no conflicts.

[netlify]

✅ Deploy Preview for authentik-storybook canceled.

Name	Link
🔨 Latest commit	48a8364
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/671d90a73c99940008472813

[netlify]

✅ Deploy Preview for authentik-docs canceled.

Name	Link
🔨 Latest commit	48a8364
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-docs/deploys/671d90a752fcc700081e6e20

[BeryJu]

While this does fix the error, ObjectExistsSyncException should be handled separately as it should fetch the data from SCIM to get the remote ID and establish the connection