Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/ldap: add rate limit delay, increase timeouts, add request to-restart #12056

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChandonPierre
Copy link
Contributor

@ChandonPierre ChandonPierre commented Nov 17, 2024

Details

We continually run into rate limiting issues syncing against an upstream Google Secure LDAP service. This PR:

  • Adds a configurable pause between page searches
  • Extends connect timeout
  • Makes ldap3 exceptions togglable
  • Changes default SYNC client strategy to RESTARTABLE to handle connection failure retries, instead of halting the sync operation

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@ChandonPierre ChandonPierre requested a review from a team as a code owner November 17, 2024 08:06
Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 8466f12
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6739a3f5407aca000855fd53

Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 8466f12
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6739a3f50e59d20008f01a4e

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.49%. Comparing base (550e24e) to head (8466f12).

❗ There is a different number of reports uploaded between BASE (550e24e) and HEAD (8466f12). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (550e24e) HEAD (8466f12)
e2e 8 7
unit 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #12056       +/-   ##
===========================================
- Coverage   92.58%   50.49%   -42.09%     
===========================================
  Files         761      759        -2     
  Lines       37863    37604      -259     
===========================================
- Hits        35057    18990    -16067     
- Misses       2806    18614    +15808     
Flag Coverage Δ
e2e 49.22% <100.00%> (+0.06%) ⬆️
integration 24.90% <50.00%> (+<0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant