Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: resize images over 1080p #6631

Merged
merged 1 commit into from
Aug 26, 2023
Merged

website: resize images over 1080p #6631

merged 1 commit into from
Aug 26, 2023

Conversation

rissson
Copy link
Member

@rissson rissson commented Aug 25, 2023

Details

Gaining some more storage (~33MB).


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Marc 'risson' Schmitt <[email protected]>
@rissson rissson self-assigned this Aug 25, 2023
@rissson rissson requested a review from a team as a code owner August 25, 2023 19:12
@rissson rissson requested review from smusali and removed request for a team August 25, 2023 19:12
@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 8a863c8
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64e8fd2641b3910008917acc
😎 Deploy Preview https://deploy-preview-6631--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 8a863c8
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/64e8fd2641b3910008917ac7
😎 Deploy Preview https://deploy-preview-6631--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b08ca98) 92.49% compared to head (8a863c8) 92.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6631   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files         561      561           
  Lines       27093    27093           
=======================================
  Hits        25056    25056           
  Misses       2037     2037           
Flag Coverage Δ
e2e 51.61% <ø> (-0.01%) ⬇️
integration 26.57% <ø> (ø)
unit 89.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-compress-images-1692991417-8a863c8
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-compress-images-1692991417-8a863c8-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-compress-images-1692991417-8a863c8

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-compress-images-1692991417-8a863c8-arm64

Afterwards, run the upgrade commands from the latest release notes.

Copy link
Member

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rissson
Copy link
Member Author

rissson commented Aug 26, 2023

Can we automate this with main/.github/workflows/image-compress.yml?

Unfortunately, no :/

@rissson rissson merged commit 13e5495 into main Aug 26, 2023
64 of 65 checks passed
@rissson rissson deleted the compress-images branch August 26, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants