Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade eslint and use the higher level CLIEngine interface #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

julienw
Copy link

@julienw julienw commented Feb 27, 2016

The current gobble-eslint does not work for me:

  • it tries to find .eslintrc but I use .eslintrc.json (which is recommended nowadays)
  • it does not use eslint 2
  • the output does not use the nice current formatter

So I redid it, using the higher level CLIEngine API that is likely more future proof as well.
But I removed the functionality about the sourcemap because I don't use it (I prefer to lint my source files than a transpiled file). So tell me what you think.
Do you think I should create a gobble-eslint-ng instead ?

This was referenced Feb 27, 2016
@julienw
Copy link
Author

julienw commented Feb 27, 2016

as a side note, I wonder if linters should not be implemented as transforms instead of observers: I think they should transform into "nothing" so that we can use them as part of the normal build without being merged. What do you think ?

@julienw
Copy link
Author

julienw commented Feb 27, 2016

Mmm this seems to work properly only as a first step, not after any other node. I'll debug this later.

@julienw
Copy link
Author

julienw commented Feb 28, 2016

I added "options.dotfiles = true" to tell eslint that it's OK if our files are in .gobble, and I filed eslint/eslint#5427 at eslint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant