Awesome 4.3 patch (lua54 compatibility) #232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awesome's
-v
version flag, was written with Lua53'srequire
in mind, which only returns 1 value. However, in Lua54, therequire
built-in now returns 2 values. Awesome doesn't handle this causing the version information to display incorrectly.Rather than checking
LUA_VERSION_NUM
, the patch handles this at runtime, so no matter the version of Lua used at build time, the runtime information should be correct for the given Lua + LGI softwares.I tested the patch with Lua versions:
5.4.3
,5.3.5
, and5.3.6
, and it works in each.Example (w/o the patch) running Lua 5.4.3 and LGI-GIT:
Example (w/ the patch)
The patch isn't essential, Awesome will run fine without it, but it's nice having the version information not be wrong ://
for Issue #128