Callable is now passed by-ref
#944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
feature
Bromeon
force-pushed
the
feature/callable-by-ref
branch
from
e21476c
to
d1d5960
Compare
Bromeon
force-pushed
the
feature/callable-by-ref
branch
from
d1d5960
to
909be4b
Compare
Bromeon
force-pushed
the
feature/callable-by-ref
branch
from
909be4b
to
856842c
Compare
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-944 |
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-944 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes APIs to accept
&Callableinstead ofCallable.Same for
&Signalbut it doesn't seem to be used in parameter position.This is mostly for consistency with #900, #906 and #940.
Now, all non-
Copybuiltins are actually passed by-ref.I'm also aware that this may cause a minor inconvenience of an added
&for ad-hoc callables (which are quite frequent), especially aroundconnect(). I don't think it's a huge deal, but we can maybe consider making those APIs more flexible in the future, to accept both owned and borrowed callables.This PR comes with some smaller cleanups.