Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the metadata command inside project command. #92

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

muaz-32
Copy link
Contributor

@muaz-32 muaz-32 commented May 28, 2024

Fixes: #91

The metadata will be added directly using the command, without using the interactive cmd. This is the fastest way to add metadata, so it has a better user experience.
For example: project metadata add [NAME|ID] ...[KEY]:[VALUE]
The same idea is used for other metadata commands.

flag: --id which means whether the argument is project ID or not. It is beneficial when a project's name is the same as another project's ID.

@muaz-32 muaz-32 marked this pull request as draft May 28, 2024 23:26
It is beneficial when a project's name is same as another project's ID.
Signed-off-by: muaz-32 <[email protected]>
Copy link
Collaborator

@amands98 amands98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !
Please check out the latest changes we've made, they significantly improve how the handler is used

@muaz-32
Copy link
Contributor Author

muaz-32 commented May 31, 2024

Thank you ! Please check out the latest changes we've made, they significantly improve how the handler is used

I have updated it accordingly. Also, I am updating my other PRs.

@muaz-32 muaz-32 marked this pull request as ready for review May 31, 2024 06:30
@muaz-32 muaz-32 closed this May 31, 2024
@muaz-32 muaz-32 reopened this May 31, 2024
@muaz-32
Copy link
Contributor Author

muaz-32 commented May 31, 2024

Thank you ! Please check out the latest changes we've made, they significantly improve how the handler is used

Regarding the new changes, how should the flags be handled? For example this PR has the isBool flag, but most other commands do not have it. So the isBool flag is not included in the ListFlags struct. I think we can create individual structs for the commands. WDYT?

@muaz-32 muaz-32 requested a review from amands98 June 2, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the metadata command for managing project metadata
2 participants