Use relUrl for SVG injection #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gokarna-hugo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Confirmed that social icons are working in the deploy preview: https://deploy-preview-256--gokarna-hugo.netlify.app/ |
|
Looks a good fix. We're generally speaking trying to undo some hard coding in the repo (#237). Hope this gets merged!
Regards,
James Davidson
…-------- Original Message --------
On 17/10/2024 10:15, Alan Cruickshank wrote:
Confirmed that social icons are working in the deploy preview: https://deploy-preview-256--gokarna-hugo.netlify.app/
—
Reply to this email directly, [view it on GitHub](#256 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/A2GRSNUVZUBVEQJWE436BLDZ355ZRAVCNFSM6AAAAABQDIRZ2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJYHE4TONRZG4).
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Looks good for me. Indeed |
|
lgtm thanks @alanmcruickshank 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #255, and builds on #249. #249 fixed non-root hosting (#237), but broke alternate-domain hosting. I believe moving from
absUrltorelUrlsolves both issues (including making sure the social icons work on the Netlify deploy previews for this repo!).Would appreciate review from @pkierski as author of #249.