forked from AY2324S1-CS2103T-W15-4/tp
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
18 changed files
with
350 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package seedu.address.commons.core; | ||
|
||
/** | ||
* Container for user visible messages. | ||
*/ | ||
public class Messages { | ||
|
||
public static final String MESSAGE_INVALID_COMMAND_FORMAT = "Invalid command format! \n%1$s"; | ||
public static final String MESSAGE_INVALID_PERSON_DISPLAYED_INDEX = "The person index provided is invalid"; | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 89 additions & 0 deletions
89
src/main/java/seedu/address/logic/commands/RemarkCommand.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
package seedu.address.logic.commands; | ||
|
||
import static seedu.address.commons.util.CollectionUtil.requireAllNonNull; | ||
import static seedu.address.model.Model.PREDICATE_SHOW_ALL_PERSONS; | ||
|
||
import seedu.address.commons.core.index.Index; | ||
import seedu.address.logic.Messages; | ||
import seedu.address.model.Model; | ||
import seedu.address.logic.commands.exceptions.CommandException; | ||
import seedu.address.model.person.Person; | ||
import seedu.address.model.person.Remark; | ||
|
||
import java.util.List; | ||
|
||
/** | ||
* Changes the remark of an existing person in the address book. | ||
*/ | ||
public class RemarkCommand extends Command { | ||
public static final String COMMAND_WORD = "remark"; | ||
public static final String MESSAGE_USAGE = COMMAND_WORD | ||
+ ": Edits the remark of the person identified " | ||
+ "by the index number used in the last person listing. " | ||
+ "Existing remark will be overwritten by the input.\n" | ||
+ "Parameters: INDEX (must be a positive integer) " | ||
+ "r/ [REMARK]\n" | ||
+ "Example: " + COMMAND_WORD + " 1 " | ||
+ "r/ Likes to swim."; | ||
public static final String MESSAGE_ARGUMENTS = "Index: %1$d, Remark: %2$s"; | ||
private final Index index; | ||
private final Remark remark; | ||
|
||
public static final String MESSAGE_ADD_REMARK_SUCCESS = "Added remark to Person: %1$s"; | ||
public static final String MESSAGE_DELETE_REMARK_SUCCESS = "Removed remark from Person: %1$s"; | ||
|
||
/** | ||
* @param index of the person in the filtered person list to edit the remark | ||
* @param remark of the person to be updated to | ||
*/ | ||
public RemarkCommand(Index index, Remark remark) { | ||
requireAllNonNull(index, remark); | ||
|
||
this.index = index; | ||
this.remark = remark; | ||
} | ||
@Override | ||
public CommandResult execute(Model model) throws CommandException { | ||
List<Person> lastShownList = model.getFilteredPersonList(); | ||
|
||
if (index.getZeroBased() >= lastShownList.size()) { | ||
throw new CommandException(Messages.MESSAGE_INVALID_PERSON_DISPLAYED_INDEX); | ||
} | ||
|
||
Person personToEdit = lastShownList.get(index.getZeroBased()); | ||
Person editedPerson = new Person( | ||
personToEdit.getName(), personToEdit.getPhone(), personToEdit.getEmail(), | ||
personToEdit.getAddress(), remark, personToEdit.getTags()); | ||
|
||
model.setPerson(personToEdit, editedPerson); | ||
model.updateFilteredPersonList(PREDICATE_SHOW_ALL_PERSONS); | ||
|
||
return new CommandResult(generateSuccessMessage(editedPerson)); | ||
} | ||
|
||
/** | ||
* Generates a command execution success message based on whether | ||
* the remark is added to or removed from | ||
* {@code personToEdit}. | ||
*/ | ||
private String generateSuccessMessage(Person personToEdit) { | ||
String message = !remark.value.isEmpty() ? MESSAGE_ADD_REMARK_SUCCESS : MESSAGE_DELETE_REMARK_SUCCESS; | ||
return String.format(message, personToEdit); | ||
} | ||
|
||
@Override | ||
public boolean equals(Object other) { | ||
if (other == this) { | ||
return true; | ||
} | ||
|
||
// instanceof handles nulls | ||
if (!(other instanceof RemarkCommand)) { | ||
return false; | ||
} | ||
|
||
RemarkCommand e = (RemarkCommand) other; | ||
return index.equals(e.index) | ||
&& remark.equals(e.remark); | ||
} | ||
} |
2 changes: 2 additions & 0 deletions
2
src/main/java/seedu/address/logic/commands/exceptions/CommandException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
src/main/java/seedu/address/logic/parser/RemarkCommandParser.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
package seedu.address.logic.parser; | ||
|
||
import static seedu.address.logic.Messages.MESSAGE_INVALID_COMMAND_FORMAT; | ||
import static seedu.address.logic.parser.CliSyntax.PREFIX_REMARK; | ||
|
||
import seedu.address.commons.core.index.Index; | ||
import seedu.address.commons.exceptions.IllegalValueException; | ||
import seedu.address.logic.commands.RemarkCommand; | ||
import seedu.address.logic.parser.exceptions.ParseException; | ||
import seedu.address.model.person.Remark; | ||
|
||
import static java.util.Objects.requireNonNull; | ||
|
||
public class RemarkCommandParser implements Parser<RemarkCommand> { | ||
/** | ||
* Parses the given {@code String} of arguments in the context of the {@code RemarkCommand} | ||
* and returns a {@code RemarkCommand} object for execution. | ||
* @throws ParseException if the user input does not conform the expected format | ||
*/ | ||
public RemarkCommand parse(String args) throws ParseException { | ||
requireNonNull(args); | ||
ArgumentMultimap argMultimap = ArgumentTokenizer.tokenize(args, PREFIX_REMARK); | ||
|
||
Index index; | ||
try { | ||
index = ParserUtil.parseIndex(argMultimap.getPreamble()); | ||
} catch (IllegalValueException ive) { | ||
throw new ParseException(String.format(MESSAGE_INVALID_COMMAND_FORMAT, RemarkCommand.MESSAGE_USAGE), ive); | ||
} | ||
|
||
Remark remark = new Remark(argMultimap.getValue(PREFIX_REMARK).orElse("")); | ||
|
||
return new RemarkCommand(index, remark); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
package seedu.address.model.person; | ||
|
||
import static java.util.Objects.requireNonNull; | ||
|
||
/** | ||
* Represents a Person's remark in the address book. | ||
* Guarantees: immutable; is always valid | ||
*/ | ||
public class Remark { | ||
public final String value; | ||
|
||
public Remark(String remark) { | ||
requireNonNull(remark); | ||
value = remark; | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return value; | ||
} | ||
|
||
@Override | ||
public boolean equals(Object other) { | ||
return other == this // short circuit if same object | ||
|| (other instanceof Remark // instanceof handles nulls | ||
&& value.equals(((Remark) other).value)); // state check | ||
} | ||
|
||
@Override | ||
public int hashCode() { | ||
return value.hashCode(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,31 +11,34 @@ | |
import seedu.address.model.person.Name; | ||
import seedu.address.model.person.Person; | ||
import seedu.address.model.person.Phone; | ||
import seedu.address.model.person.Remark; | ||
import seedu.address.model.tag.Tag; | ||
|
||
/** | ||
* Contains utility methods for populating {@code AddressBook} with sample data. | ||
*/ | ||
public class SampleDataUtil { | ||
public static final Remark EMPTY_REMARK = new Remark(""); | ||
|
||
public static Person[] getSamplePersons() { | ||
return new Person[] { | ||
new Person(new Name("Alex Yeoh"), new Phone("87438807"), new Email("[email protected]"), | ||
new Address("Blk 30 Geylang Street 29, #06-40"), | ||
new Address("Blk 30 Geylang Street 29, #06-40"), EMPTY_REMARK, | ||
getTagSet("friends")), | ||
new Person(new Name("Bernice Yu"), new Phone("99272758"), new Email("[email protected]"), | ||
new Address("Blk 30 Lorong 3 Serangoon Gardens, #07-18"), | ||
new Address("Blk 30 Lorong 3 Serangoon Gardens, #07-18"), EMPTY_REMARK, | ||
getTagSet("colleagues", "friends")), | ||
new Person(new Name("Charlotte Oliveiro"), new Phone("93210283"), new Email("[email protected]"), | ||
new Address("Blk 11 Ang Mo Kio Street 74, #11-04"), | ||
new Address("Blk 11 Ang Mo Kio Street 74, #11-04"), EMPTY_REMARK, | ||
getTagSet("neighbours")), | ||
new Person(new Name("David Li"), new Phone("91031282"), new Email("[email protected]"), | ||
new Address("Blk 436 Serangoon Gardens Street 26, #16-43"), | ||
new Address("Blk 436 Serangoon Gardens Street 26, #16-43"), EMPTY_REMARK, | ||
getTagSet("family")), | ||
new Person(new Name("Irfan Ibrahim"), new Phone("92492021"), new Email("[email protected]"), | ||
new Address("Blk 47 Tampines Street 20, #17-35"), | ||
new Address("Blk 47 Tampines Street 20, #17-35"), EMPTY_REMARK, | ||
getTagSet("classmates")), | ||
new Person(new Name("Roy Balakrishnan"), new Phone("92624417"), new Email("[email protected]"), | ||
new Address("Blk 45 Aljunied Street 85, #11-31"), | ||
new Address("Blk 45 Aljunied Street 85, #11-31"), EMPTY_REMARK, | ||
getTagSet("colleagues")) | ||
}; | ||
} | ||
|
Oops, something went wrong.