feat: support basic alert for remaining visualizations

JIRA: F1-773
gooddata · Oct 2, 2024 · 200de3e · 200de3e
1 parent 48f4c9d
commit 200de3e
Show file tree

Hide file tree

Showing 2 changed files with 63 additions and 36 deletions.
diff --git a/...dk-ui-dashboard/src/presentation/widget/insight/configuration/InsightAlertConfig/utils.ts b/...dk-ui-dashboard/src/presentation/widget/insight/configuration/InsightAlertConfig/utils.ts
@@ -247,6 +247,13 @@ function collectAllMetric(insight: IInsight | null | undefined): {
 } {
     const insightType = insight ? (insightVisualizationType(insight) as InsightType) : null;
 
+    if (!insight) {
+        return {
+            primaries: [],
+            others: [],
+        };
+    }
+
     switch (insightType) {
         case "headline":
         case "bar":
@@ -255,47 +262,24 @@ function collectAllMetric(insight: IInsight | null | undefined): {
         case "area":
         case "combo2":
         case "scatter":
-        case "bubble": {
-            const insightMeasuresBucket: IBucket | undefined = insight
-                ? insightBucket(insight, BucketNames.MEASURES)
-                : undefined;
-            const insightSecondaryMeasuresBucket: IBucket | undefined = insight
-                ? insightBucket(insight, BucketNames.SECONDARY_MEASURES)
-                : undefined;
-            const insightTertiaryMeasuresBucket: IBucket | undefined = insight
-                ? insightBucket(insight, BucketNames.TERTIARY_MEASURES)
-                : undefined;
-
-            return {
-                primaries: insightMeasuresBucket ? bucketMeasures(insightMeasuresBucket) : [],
-                others: [
-                    ...(insightSecondaryMeasuresBucket ? bucketMeasures(insightSecondaryMeasuresBucket) : []),
-                    ...(insightTertiaryMeasuresBucket ? bucketMeasures(insightTertiaryMeasuresBucket) : []),
-                ],
-            };
-        }
-        case "repeater": {
-            const insightColumnsBucket: IBucket | undefined = insight
-                ? insightBucket(insight, BucketNames.COLUMNS)
-                : undefined;
-
-            return {
-                primaries: insightColumnsBucket ? bucketMeasures(insightColumnsBucket) : [],
-                others: [],
-            };
-        }
-        case "donut":
-        case "treemap":
-        case "heatmap":
+        case "bubble":
         case "bullet":
-        case "table":
-        case "pushpin":
         case "pie":
-        case "sankey":
-        case "dependencywheel":
+        case "donut":
+        case "treemap":
         case "funnel":
         case "pyramid":
+        case "heatmap":
         case "waterfall":
+        case "dependencywheel":
+        case "sankey":
+        case "pushpin":
+        case "table": {
+            return collectAllMetricsDefault(insight);
+        }
+        case "repeater": {
+            return collectAllMetricsRepeater(insight);
+        }
         default: {
             return {
                 primaries: [],
@@ -305,6 +289,37 @@ function collectAllMetric(insight: IInsight | null | undefined): {
     }
 }
 
+function collectAllMetricsDefault(insight: IInsight) {
+    const insightMeasuresBucket: IBucket | undefined = insight
+        ? insightBucket(insight, BucketNames.MEASURES)
+        : undefined;
+    const insightSecondaryMeasuresBucket: IBucket | undefined = insight
+        ? insightBucket(insight, BucketNames.SECONDARY_MEASURES)
+        : undefined;
+    const insightTertiaryMeasuresBucket: IBucket | undefined = insight
+        ? insightBucket(insight, BucketNames.TERTIARY_MEASURES)
+        : undefined;
+
+    return {
+        primaries: insightMeasuresBucket ? bucketMeasures(insightMeasuresBucket) : [],
+        others: [
+            ...(insightSecondaryMeasuresBucket ? bucketMeasures(insightSecondaryMeasuresBucket) : []),
+            ...(insightTertiaryMeasuresBucket ? bucketMeasures(insightTertiaryMeasuresBucket) : []),
+        ],
+    };
+}
+
+function collectAllMetricsRepeater(insight: IInsight) {
+    const insightColumnsBucket: IBucket | undefined = insight
+        ? insightBucket(insight, BucketNames.COLUMNS)
+        : undefined;
+
+    return {
+        primaries: insightColumnsBucket ? bucketMeasures(insightColumnsBucket) : [],
+        others: [],
+    };
+}
+
 export function getValueSuffix(alert?: IAutomationAlert): string | undefined {
     if (isChangeOperator(alert)) {
         return "%";

diff --git a/libs/sdk-ui-ext/src/internal/components/pluggableVisualizations/alerts.ts b/libs/sdk-ui-ext/src/internal/components/pluggableVisualizations/alerts.ts
@@ -26,6 +26,18 @@ export const isInsightSupportedForAlerts = (
         case "scatter":
         case "bubble":
         case "repeater":
+        case "bullet":
+        case "pie":
+        case "donut":
+        case "treemap":
+        case "funnel":
+        case "pyramid":
+        case "heatmap":
+        case "waterfall":
+        case "dependencywheel":
+        case "sankey":
+        case "pushpin":
+        case "table":
             return true;
         default:
             return false;