Merge pull request #5071 from gooddata/ine-lx-336

fix: proper query options when searching
gooddata · Jun 27, 2024 · 69b5f0d · 69b5f0d
2 parents 01bb4ca + c679d1f
commit 69b5f0d
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/libs/sdk-ui-filters/src/AttributeFilterHandler/internal/redux/elements/elementsSaga.ts b/libs/sdk-ui-filters/src/AttributeFilterHandler/internal/redux/elements/elementsSaga.ts
@@ -41,6 +41,13 @@ export function* elementsSaga(
 
     const { enableDuplicatedLabelValuesInAttributeFilter } = context;
 
+    const filterByPrimaryLabelProp =
+        enableDuplicatedLabelValuesInAttributeFilter &&
+        attributeFilterDisplayAsDisplayFormRef &&
+        !options.search // when searching by string, we need to apply it to the displayAsLabel directly not primary label
+            ? { filterByPrimaryLabel: true }
+            : {};
+
     const elementsQueryResult: PromiseFnReturnType<typeof loadElements> = yield call(
         loadElements,
         context,
@@ -50,9 +57,7 @@ export function* elementsSaga(
                     ? attributeFilterDisplayAsDisplayFormRef
                     : attributeFilterDisplayFormRef,
             ...options,
-            ...(enableDuplicatedLabelValuesInAttributeFilter && attributeFilterDisplayAsDisplayFormRef
-                ? { filterByPrimaryLabel: true }
-                : {}),
+            ...filterByPrimaryLabelProp,
         },
         {
             hiddenElements,