fix: use valid IETF BCP 47 zh-HK code

JIRA: LX-454
gooddata · Aug 16, 2024 · 9297c4e · 9297c4e
1 parent 90cb89e
commit 9297c4e
Show file tree

Hide file tree

Showing 12 changed files with 14 additions and 14 deletions.
diff --git a/...entation/localization/bundles/zh-Yue.json → ...sentation/localization/bundles/zh-HK.json b/...entation/localization/bundles/zh-Yue.json → ...sentation/localization/bundles/zh-HK.json
diff --git a/libs/sdk-ui-dashboard/src/presentation/localization/translations.ts b/libs/sdk-ui-dashboard/src/presentation/localization/translations.ts
@@ -19,7 +19,7 @@ import frCA from "./bundles/fr-CA.json";
 import enGB from "./bundles/en-GB.json";
 import enAU from "./bundles/en-AU.json";
 import zhHant from "./bundles/zh-Hant.json";
-import zhYue from "./bundles/zh-Yue.json";
+import zhHK from "./bundles/zh-HK.json";
 import fiFI from "./bundles/fi-FI.json";
 
 const sdkUiDashboardTranslations: { [locale: string]: Record<string, string> } = {
@@ -40,7 +40,7 @@ const sdkUiDashboardTranslations: { [locale: string]: Record<string, string> } =
     "en-AU": enAU,
     "fi-FI": fiFI,
     "zh-Hant": zhHant,
-    yue: zhYue,
+    "zh-HK": zhHK,
 };
 
 /**

diff --git a/...ext/src/internal/translations/zh-Yue.json → ...-ext/src/internal/translations/zh-HK.json b/...ext/src/internal/translations/zh-Yue.json → ...-ext/src/internal/translations/zh-HK.json
diff --git a/libs/sdk-ui-ext/src/internal/utils/translations.ts b/libs/sdk-ui-ext/src/internal/utils/translations.ts
@@ -21,7 +21,7 @@ import enGB from "../translations/en-GB.json";
 import enAU from "../translations/en-AU.json";
 import fiFI from "../translations/fi-FI.json";
 import zhHant from "../translations/zh-Hant.json";
-import zhYue from "../translations/zh-Yue.json";
+import zhHK from "../translations/zh-HK.json";
 
 import { IDropdownItem } from "../interfaces/Dropdown.js";
 
@@ -59,7 +59,7 @@ const sdkUiExtTranslations: { [locale: string]: Record<string, string> } = {
     "en-AU": enAU,
     "fi-FI": fiFI,
     "zh-Hant": zhHant,
-    yue: zhYue,
+    "zh-HK": zhHK,
 };
 
 /**

diff --git a/libs/sdk-ui-kit/src/Dialog/EmbedInsightDialog/EmbedInsightDialogBase/types.ts b/libs/sdk-ui-kit/src/Dialog/EmbedInsightDialog/EmbedInsightDialogBase/types.ts
@@ -53,7 +53,7 @@ export const LOCALES: ILocale[] = [
     "en-AU",
     "fi-FI",
     "zh-Hant",
-    "yue",
+    "zh-HK",
 ];
 export const DEFAULT_LOCALE = "en-US";
 

diff --git a/libs/sdk-ui/api/sdk-ui.api.md b/libs/sdk-ui/api/sdk-ui.api.md
@@ -1018,7 +1018,7 @@ export interface ILoadingState {
 }
 
 // @public
-export type ILocale = "en-US" | "de-DE" | "es-ES" | "fr-FR" | "ja-JP" | "nl-NL" | "pt-BR" | "pt-PT" | "zh-Hans" | "ru-RU" | "it-IT" | "es-419" | "fr-CA" | "en-GB" | "en-AU" | "fi-FI" | "zh-Hant" | "yue";
+export type ILocale = "en-US" | "de-DE" | "es-ES" | "fr-FR" | "ja-JP" | "nl-NL" | "pt-BR" | "pt-PT" | "zh-Hans" | "ru-RU" | "it-IT" | "es-419" | "fr-CA" | "en-GB" | "en-AU" | "fi-FI" | "zh-Hant" | "zh-HK";
 
 // @public (undocumented)
 export type IMappingHeader = IAttributeDescriptor | IResultAttributeHeader | IMeasureDescriptor | ITotalDescriptor | IColorDescriptor;

diff --git a/libs/sdk-ui/src/base/localization/Locale.ts b/libs/sdk-ui/src/base/localization/Locale.ts
@@ -23,7 +23,7 @@ export type ILocale =
     | "en-AU"
     | "fi-FI"
     | "zh-Hant"
-    | "yue";
+    | "zh-HK";
 
 /**
  * Array of locales for type-guard. It must be the same as {@link ILocale}
@@ -48,7 +48,7 @@ export const LOCALES = [
     "en-AU",
     "fi-FI",
     "zh-Hant",
-    "yue",
+    "zh-HK",
 ];
 
 /**

diff --git a/...src/base/localization/bundles/zh-Yue.json → .../src/base/localization/bundles/zh-HK.json b/...src/base/localization/bundles/zh-Yue.json → .../src/base/localization/bundles/zh-HK.json
diff --git a/libs/sdk-ui/src/base/localization/messagesMap.ts b/libs/sdk-ui/src/base/localization/messagesMap.ts
@@ -18,7 +18,7 @@ import enGB from "./bundles/en-GB.json";
 import enAU from "./bundles/en-AU.json";
 import fiFI from "./bundles/fi-FI.json";
 import zhHant from "./bundles/zh-Hant.json";
-import zhYue from "./bundles/zh-Yue.json";
+import zhHK from "./bundles/zh-HK.json";
 
 /**
  * @internal
@@ -48,5 +48,5 @@ export const messagesMap: { [locale: string]: ITranslations } = {
     "en-AU": enAU,
     "fi-FI": fiFI,
     "zh-Hant": zhHant,
-    yue: zhYue,
+    "zh-HK": zhHK,
 };
diff --git a/libs/sdk-ui/src/base/localization/test/IntlStore.test.ts b/libs/sdk-ui/src/base/localization/test/IntlStore.test.ts
@@ -48,7 +48,7 @@ describe("IntlStore", () => {
                 "en-AU",
                 "fi-FI",
                 "zh-Hant",
-                "yue",
+                "zh-HK",
             ];
 
             it("should return message in en-US", () => {

diff --git a/libs/util/src/tests/translationUtils.test.ts b/libs/util/src/tests/translationUtils.test.ts
@@ -39,9 +39,9 @@ describe("sanitizeLocaleForMoment", () => {
         expect(actual).toEqual(expected);
     });
 
-    it("should sanitize the yue locale", () => {
+    it("should sanitize the zh-HK locale", () => {
         const expected = "zh-CN";
-        const actual = sanitizeLocaleForMoment("yue");
+        const actual = sanitizeLocaleForMoment("zh-HK");
         expect(actual).toEqual(expected);
     });
 

diff --git a/libs/util/src/translationUtils.ts b/libs/util/src/translationUtils.ts
@@ -25,7 +25,7 @@ export function removeMetadata(translationsWithMetadata: Record<string, any>): R
  * @internal
  */
 export const sanitizeLocaleForMoment = (intlLocale: string): string => {
-    if (intlLocale === "zh-Hans" || intlLocale === "zh-Hant" || intlLocale === "yue") {
+    if (intlLocale === "zh-Hans" || intlLocale === "zh-Hant" || intlLocale === "zh-HK") {
         return "zh-CN";
     }
     return intlLocale;