Merge pull request #5478 from gooddata/pdo-lx-586-nested-layout-view-…

…mode feat: introduce feature flag for dashboard nested layout feature
gooddata · Oct 16, 2024 · 95ab0a4 · 95ab0a4
2 parents afc0419 + e146544
commit 95ab0a4
Show file tree

Hide file tree

Showing 7 changed files with 30 additions and 0 deletions.
diff --git a/libs/sdk-backend-tiger/src/backend/features/feature.ts b/libs/sdk-backend-tiger/src/backend/features/feature.ts
@@ -548,6 +548,13 @@ export function mapFeatures(features: FeaturesMap): Partial<ITigerFeatureFlags>
             "BOOLEAN",
             FeatureFlagsValues.enableDefaultSmtp,
         ),
+        ...loadFeature(
+            features,
+            TigerFeaturesNames.EnableDashboardNestedLayout,
+            "enableDashboardNestedLayout",
+            "BOOLEAN",
+            FeatureFlagsValues.enableDashboardNestedLayout,
+        ),
     };
 }
 

diff --git a/libs/sdk-backend-tiger/src/backend/uiFeatures.ts b/libs/sdk-backend-tiger/src/backend/uiFeatures.ts
@@ -116,6 +116,7 @@ export enum TigerFeaturesNames {
     EnableEarlyAccessFeaturesRollout = "enableEarlyAccessFeaturesRollout",
     EnableCrossFilteringAliasTitles = "enableCrossFilteringAliasTitles",
     EnableDefaultSmtp = "enableDefaultSmtp",
+    EnableDashboardNestedLayout = "enableDashboardNestedLayout",
 }
 
 export type ITigerFeatureFlags = {
@@ -195,6 +196,7 @@ export type ITigerFeatureFlags = {
     enableEarlyAccessFeaturesRollout: typeof FeatureFlagsValues["enableEarlyAccessFeaturesRollout"][number];
     enableCrossFilteringAliasTitles: typeof FeatureFlagsValues["enableCrossFilteringAliasTitles"][number];
     enableDefaultSmtp: typeof FeatureFlagsValues["enableDefaultSmtp"][number];
+    enableDashboardNestedLayout: typeof FeatureFlagsValues["enableDashboardNestedLayout"][number];
 };
 
 export const DefaultFeatureFlags: ITigerFeatureFlags = {
@@ -274,6 +276,7 @@ export const DefaultFeatureFlags: ITigerFeatureFlags = {
     enableEarlyAccessFeaturesRollout: false,
     enableCrossFilteringAliasTitles: false,
     enableDefaultSmtp: false,
+    enableDashboardNestedLayout: false,
 };
 
 export const FeatureFlagsValues = {
@@ -357,4 +360,5 @@ export const FeatureFlagsValues = {
     enableEarlyAccessFeaturesRollout: [true, false] as const,
     enableCrossFilteringAliasTitles: [true, false] as const,
     enableDefaultSmtp: [true, false] as const,
+    enableDashboardNestedLayout: [true, false] as const,
 };
diff --git a/libs/sdk-model/api/sdk-model.api.md b/libs/sdk-model/api/sdk-model.api.md
@@ -3107,6 +3107,7 @@ export interface ISettings {
     enableCsvUploader?: boolean;
     enableCustomColorPicker?: boolean;
     enableDashboardFilterViews?: boolean;
+    enableDashboardNestedLayout?: boolean;
     enableDataSampling?: boolean;
     // (undocumented)
     enableDataSection?: boolean;

diff --git a/libs/sdk-model/src/settings/index.ts b/libs/sdk-model/src/settings/index.ts
@@ -446,6 +446,11 @@ export interface ISettings {
     enableMotherDuckDataSource?: boolean;
     enableSingleStoreDataSource?: boolean;
 
+    /**
+     * Enables new dashboard layout renderer with nesting support.
+     */
+    enableDashboardNestedLayout?: boolean;
+
     /**
      * Enable GenAI-powered functionality, such as semantic-search.
      * @deprecated Use separate flags for semantic search and GenAI chat below.

diff --git a/libs/sdk-ui-dashboard/api/sdk-ui-dashboard.api.md b/libs/sdk-ui-dashboard/api/sdk-ui-dashboard.api.md
@@ -7449,6 +7449,9 @@ export const selectEnableKPIDashboardScheduleRecipients: DashboardSelector<boole
 // @internal
 export const selectEnableMultipleDateFilters: DashboardSelector<boolean>;
 
+// @internal
+export const selectEnableNestedLayout: DashboardSelector<boolean>;
+
 // @internal
 export const selectEnableRenamingMeasureToMetric: DashboardSelector<boolean>;
 

diff --git a/libs/sdk-ui-dashboard/src/model/store/config/configSelectors.ts b/libs/sdk-ui-dashboard/src/model/store/config/configSelectors.ts
@@ -767,3 +767,12 @@ export const selectEnableCrossFilteringAliasTitles: DashboardSelector<boolean> =
         return state.settings?.enableCrossFilteringAliasTitles ?? false;
     },
 );
+
+/**
+ * Returns whether nested layout is enabled.
+ *
+ * @internal
+ */
+export const selectEnableNestedLayout: DashboardSelector<boolean> = createSelector(selectConfig, (state) => {
+    return state.settings?.enableDashboardNestedLayout ?? false;
+});
diff --git a/libs/sdk-ui-dashboard/src/model/store/index.ts b/libs/sdk-ui-dashboard/src/model/store/index.ts
@@ -95,6 +95,7 @@ export {
     selectEnableIgnoreCrossFiltering,
     selectEnableAutomations,
     selectEnableCrossFilteringAliasTitles,
+    selectEnableNestedLayout,
 } from "./config/configSelectors.js";
 export type { EntitlementsState } from "./entitlements/entitlementsState.js";
 export {