Skip to content

Commit

Permalink
Merge pull request #4976 from xMort/pdo-lx-258
Browse files Browse the repository at this point in the history
feat: introduce new feature flag for multiple data sources in workspace

Reviewed-by: Petr Dolejší <[email protected]>
             https://github.com/xMort
  • Loading branch information
gdgate authored May 13, 2024
2 parents b5bc629 + ca87dd7 commit ba1115e
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 0 deletions.
7 changes: 7 additions & 0 deletions libs/sdk-backend-tiger/src/backend/features/feature.ts
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,13 @@ export function mapFeatures(features: FeaturesMap): Partial<ITigerFeatureFlags>
"BOOLEAN",
FeatureFlagsValues.enableWorkspacesHierarchyView,
),
...loadFeature(
features,
TigerFeaturesNames.EnableMultipleDataSourcesInWorkspace,
"enableMultipleDataSourcesInWorkspace",
"BOOLEAN",
FeatureFlagsValues.enableMultipleDataSourcesInWorkspace,
),
};
}

Expand Down
4 changes: 4 additions & 0 deletions libs/sdk-backend-tiger/src/backend/uiFeatures.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ export enum TigerFeaturesNames {
EnableInvalidValuesInAttributeFilter = "enableInvalidValuesInAttributeFilter",
EnableDuplicatedLabelValuesInAttributeFilter = "enableDuplicatedLabelValuesInAttributeFilter",
EnableWorkspacesHierarchyView = "enableWorkspacesHierarchyView",
EnableMultipleDataSourcesInWorkspace = "enableMultipleDataSourcesInWorkspace",
}

export type ITigerFeatureFlags = {
Expand Down Expand Up @@ -142,6 +143,7 @@ export type ITigerFeatureFlags = {
enableInvalidValuesInAttributeFilter: typeof FeatureFlagsValues["enableInvalidValuesInAttributeFilter"][number];
enableDuplicatedLabelValuesInAttributeFilter: typeof FeatureFlagsValues["enableDuplicatedLabelValuesInAttributeFilter"][number];
enableWorkspacesHierarchyView: typeof FeatureFlagsValues["enableWorkspacesHierarchyView"][number];
enableMultipleDataSourcesInWorkspace: typeof FeatureFlagsValues["enableMultipleDataSourcesInWorkspace"][number];
};

export const DefaultFeatureFlags: ITigerFeatureFlags = {
Expand Down Expand Up @@ -195,6 +197,7 @@ export const DefaultFeatureFlags: ITigerFeatureFlags = {
enableInvalidValuesInAttributeFilter: false,
enableDuplicatedLabelValuesInAttributeFilter: false,
enableWorkspacesHierarchyView: false,
enableMultipleDataSourcesInWorkspace: false,
};

export const FeatureFlagsValues = {
Expand Down Expand Up @@ -252,4 +255,5 @@ export const FeatureFlagsValues = {
enableInvalidValuesInAttributeFilter: [true, false] as const,
enableDuplicatedLabelValuesInAttributeFilter: [true, false] as const,
enableWorkspacesHierarchyView: [true, false] as const,
enableMultipleDataSourcesInWorkspace: [true, false] as const,
};
1 change: 1 addition & 0 deletions libs/sdk-model/api/sdk-model.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -2647,6 +2647,7 @@ export interface ISettings {
enableKPIDashboardSchedule?: boolean;
enableKPIDashboardScheduleRecipients?: boolean;
enableMultipleCSVs?: boolean;
enableMultipleDataSourcesInWorkspace?: boolean;
enableMultipleDateFilters?: boolean;
enableMultipleDates?: boolean;
enableNewHeadline?: boolean;
Expand Down
5 changes: 5 additions & 0 deletions libs/sdk-model/src/settings/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,11 @@ export interface ISettings {
*/
enableWorkspacesHierarchyView?: boolean;

/**
* Enable multiple data sources to be used in a single workspace.
*/
enableMultipleDataSourcesInWorkspace?: boolean;

[key: string]: number | boolean | string | object | undefined;
}

Expand Down

0 comments on commit ba1115e

Please sign in to comment.