-
Notifications
You must be signed in to change notification settings - Fork 119
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: move AddButton component to ui-kit
JIRA: F1-437 risk: low
- Loading branch information
1 parent
732f379
commit c29fbe8
Showing
8 changed files
with
139 additions
and
63 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 0 additions & 57 deletions
57
...entation/scheduledEmail/DefaultScheduledEmailManagementDialog/components/CreateButton.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| // (C) 2024 GoodData Corporation | ||
|
|
||
| import React, { useCallback } from "react"; | ||
| import cx from "classnames"; | ||
| import { BubbleHoverTrigger } from "../Bubble/BubbleHoverTrigger.js"; | ||
| import { Button } from "../Button/Button.js"; | ||
| import { Bubble } from "../Bubble/Bubble.js"; | ||
| import { IAlignPoint } from "../typings/positioning.js"; | ||
|
|
||
| const defaultTooltipAlignPoints = [{ align: "cr cl" }, { align: "cl cr" }]; | ||
|
|
||
| /** | ||
| * @internal | ||
| */ | ||
| export interface IAddButtonProps { | ||
| title: JSX.Element; | ||
| isDisabled?: boolean; | ||
| onClick?: () => void; | ||
| tooltip?: JSX.Element; | ||
| tooltipAlignPoints?: IAlignPoint[]; | ||
| className?: string; | ||
| } | ||
|
|
||
| /** | ||
| * @internal | ||
| */ | ||
| export const AddButton: React.FC<IAddButtonProps> = (props) => { | ||
| const { | ||
| title, | ||
| isDisabled, | ||
| onClick, | ||
| tooltip, | ||
| tooltipAlignPoints = defaultTooltipAlignPoints, | ||
| className, | ||
| } = props; | ||
|
|
||
| const buttonClassNames = cx( | ||
| { | ||
| disabled: isDisabled, | ||
| }, | ||
| "gd-button-link", | ||
| "gd-icon-plus", | ||
| "s-add-button", | ||
| className, | ||
| ); | ||
|
|
||
| const handleClick = useCallback( | ||
| (e: React.MouseEvent) => { | ||
| e.preventDefault(); | ||
| if (isDisabled) { | ||
| return; | ||
| } | ||
| onClick?.(); | ||
| }, | ||
| [isDisabled, onClick], | ||
| ); | ||
|
|
||
| if (!tooltip) { | ||
| return ( | ||
| <Button className={buttonClassNames} onClick={handleClick}> | ||
| {title} | ||
| </Button> | ||
| ); | ||
| } | ||
|
|
||
| return ( | ||
| <BubbleHoverTrigger showDelay={0} hideDelay={0}> | ||
| <Button className={buttonClassNames} onClick={handleClick}> | ||
| {title} | ||
| </Button> | ||
| <Bubble className="bubble-primary" alignPoints={tooltipAlignPoints}> | ||
| {tooltip} | ||
| </Bubble> | ||
| </BubbleHoverTrigger> | ||
| ); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| // (C) 2024 GoodData Corporation | ||
|
|
||
| export { AddButton, IAddButtonProps } from "./AddButton.js"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
libs/sdk-ui-tests/stories/visual-regression/kit/AddButton/AddButton.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // (C) 2024 GoodData Corporation | ||
|
|
||
| import React from "react"; | ||
| import { storiesOf } from "../../../_infra/storyRepository.js"; | ||
| import { UiKit } from "../../../_infra/storyGroups.js"; | ||
| import { wrapWithTheme } from "../../themeWrapper.js"; | ||
| import { AddButton } from "@gooddata/sdk-ui-kit"; | ||
| import { action } from "@storybook/addon-actions"; | ||
|
|
||
| const onClick = () => { | ||
| action("onClick"); | ||
| }; | ||
|
|
||
| const AddButtonTest = () => { | ||
| return ( | ||
| <div className="library-component screenshot-target"> | ||
| <h4>Default</h4> | ||
| <AddButton title={<>Create</>} onClick={onClick} /> | ||
|
|
||
| <h4>Disabled</h4> | ||
| <AddButton title={<>Can't touch this</>} isDisabled={true} onClick={onClick} /> | ||
|
|
||
| <h4>With tooltip</h4> | ||
| <AddButton title={<>Hover</>} tooltip={<>Some information here!</>} onClick={onClick} /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| storiesOf(`${UiKit}/AddButton`) | ||
| .add("full-featured", () => <AddButtonTest />, { screenshot: true }) | ||
| .add("themed", () => wrapWithTheme(<AddButtonTest />), { screenshot: true }); |