RELATED: F1-645 Semantic search hardening #5411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 30, 2024 17:44
- post-css produces invalid content, work around it jira: F1-645 risk: low
- Added accessibility area-label to the search results icon jira: F1-645 risk: low
- Move results item tooltip to the left to allow easier results surfing jira: F1-645 risk: low
- added stylelint and fixed issues - dropped deprecated API from sdk-model jira: F1-645 risk: low
- localizations related to semantic search now located in the same package jira: F1-645 risk: low
|
extended test - backstop |
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/21937/ finished with 'SUCCESS' status. |
|
Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2291/ finished with 'SUCCESS' status. |
pbenes
approved these changes
Oct 1, 2024
|
Job gooddata-ui-sdk-cypress-tiger-isolated-zuul-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-cypress-tiger-isolated-zuul-pipeline/2527/ finished with 'SUCCESS' status. |
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/21939/ finished with 'SUCCESS' status. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdk-uiImportant
Please, don't forget to run
rush changefor the commits that introduce new features 🙏Refer to documentation to see how to run checks and tests in the pull request. This is the list of the most used commands: