Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default_metadata for files API. #548

Merged
merged 7 commits into from
Sep 11, 2024

Conversation

MarkDaoust
Copy link
Collaborator

@MarkDaoust MarkDaoust commented Sep 10, 2024

Fix files client to handle metadata and default_metadata.

Change-Id: Ibba74ccda137fe4ac62525868e036a0a0d612348
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Sep 10, 2024
Change-Id: If8f938a1026d46aafc617d1c0e95360c463f0ba0
@MarkDaoust
Copy link
Collaborator Author

@psbang

@MarkDaoust MarkDaoust marked this pull request as draft September 10, 2024 22:36
Change-Id: I9449c6f3299f820fea4128cb598f39cf359cd9ef
Change-Id: I4133647fbea3b6b995ed6edf56bd2a243c2131af
Change-Id: Ibb8740fd548cc8a8a75b32508d6d05aa6e89f633
Change-Id: I9647c47718d7b6981692b484b9e9b2ed0f9a42cc
Change-Id: Ie49216fef5eb13e202fd276fff62e7e20f03b062
@MarkDaoust MarkDaoust marked this pull request as ready for review September 11, 2024 18:46
@MarkDaoust
Copy link
Collaborator Author

I got a confirmation from psbang that this solves their issues on kaggle.

@shilpakancharla could I get a quick review? I'd like to submit this ad release a 0.81 today.

@shilpakancharla shilpakancharla merged commit 90f8094 into google-gemini:main Sep 11, 2024
10 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants