Update text_generation.py #557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status:awaiting review
MarkDaoust
reviewed
Sep 27, 2024
| import google.generativeai as genai | ||
| import os | ||
|
|
||
| genai.configure(api_key=os.environ["GOOGLE_API_KEY"]) |
There was a problem hiding this comment.
If the API key is set as an environment variable the SDK will automatically pick it up. Do we still want this?
| @@ -23,15 +23,19 @@ | |||
| class UnitTests(absltest.TestCase): | |||
| def test_text_gen_text_only_prompt(self): | |||
| # [START text_gen_text_only_prompt] | |||
| import google.generativeai as genai | |||
There was a problem hiding this comment.
We could require the import in each sample.
The trade-off is just signal-to-noise ratio.
If we expect each sample to be runnable with just a copy-paste from the site.. some things become difficult: A sample for tunedModel.delete requires that you train a tuned model first, that's a case where the signal to noise ratio is really bad.
|
Caught up with @logankilpatrick async, we'll close this and do something different instead. |
github-actions
bot
removed
the
status:awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the quickstart and text generation snippets