Skip to content
This repository has been archived by the owner on Nov 7, 2024. It is now read-only.

Fix imps #902

Merged
merged 8 commits into from
Jan 21, 2021
Merged

Fix imps #902

merged 8 commits into from
Jan 21, 2021

Conversation

mganahl
Copy link
Contributor

@mganahl mganahl commented Jan 12, 2021

depends on #901
fixes #896

@google-cla google-cla bot added the cla: yes label Jan 12, 2021
@mganahl mganahl requested a review from alewis January 12, 2021 14:21
@codecov-io
Copy link

codecov-io commented Jan 12, 2021

Codecov Report

Merging #902 (f691ed8) into master (852638b) will decrease coverage by 0.00%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #902      +/-   ##
==========================================
- Coverage   98.13%   98.12%   -0.01%     
==========================================
  Files         129      129              
  Lines       22748    22780      +32     
==========================================
+ Hits        22323    22354      +31     
- Misses        425      426       +1     
Impacted Files Coverage Δ
tensornetwork/backends/abstract_backend.py 91.35% <50.00%> (-0.52%) ⬇️
tensornetwork/backends/jax/jax_backend.py 98.86% <100.00%> (+<0.01%) ⬆️
tensornetwork/backends/jax/jax_backend_test.py 99.27% <100.00%> (+<0.01%) ⬆️
tensornetwork/backends/numpy/numpy_backend.py 98.05% <100.00%> (+0.01%) ⬆️
tensornetwork/backends/numpy/numpy_backend_test.py 99.30% <100.00%> (+<0.01%) ⬆️
tensornetwork/backends/pytorch/pytorch_backend.py 99.50% <100.00%> (+<0.01%) ⬆️
...ornetwork/backends/pytorch/pytorch_backend_test.py 100.00% <100.00%> (ø)
...sornetwork/backends/symmetric/symmetric_backend.py 99.30% <100.00%> (+<0.01%) ⬆️
...twork/backends/symmetric/symmetric_backend_test.py 100.00% <100.00%> (ø)
...rnetwork/backends/tensorflow/tensorflow_backend.py 98.24% <100.00%> (+0.02%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 852638b...f691ed8. Read the comment docs.

@mganahl
Copy link
Contributor Author

mganahl commented Jan 14, 2021

@alewis review appreciated! thanks!

@mganahl
Copy link
Contributor Author

mganahl commented Jan 18, 2021

@jacksonwb @alewis ping for review

@jacksonwb
Copy link
Contributor

@mganahl isn't this pretty much already done in #901 ?

@mganahl
Copy link
Contributor Author

mganahl commented Jan 20, 2021

Thanks @jacksonwb, I think I actually forgot to commit the changes :0

for simulations with negative small schmidt values due to finite precision arithmetic, sqrt operations resulted in NaNs.
This change fixes this.
@mganahl
Copy link
Contributor Author

mganahl commented Jan 20, 2021

Changes are pushed, would be great if you could have a quick look. Thanks!

Copy link
Contributor

@jacksonwb jacksonwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mganahl mganahl merged commit 8b94e26 into google:master Jan 21, 2021
@mganahl mganahl deleted the fix_imps branch January 21, 2021 23:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numpy.linalg.LinAlgError: SVD did not converge
3 participants