Fix App Attest and DeviceCheck API availability #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the GAC_DEVICE_CHECK_PROVIDER_AVAILABILITY and GAC_APP_ATTEST_PROVIDER_AVAILABILITY API availability macros to reflect the set of supported platforms for DeviceCheck (iOS 11+, macOS 10.15+, macCatalyst 13+, tvOS 11+, watchOS 9+) and App Attest (iOS 14+, macOS 11.3+, macCatalyst 14.5+, tvOS 15+, watchOS 9+). - Removed the extraneous check for the watchOS 9 SDK now that Xcode 14 is the minimum supported by Firebase.
paulb777
approved these changes
Aug 11, 2023
| provider.getToken { token, error in | ||
| // ... | ||
| } | ||
| if #available(iOS 14.0, macOS 11.3, macCatalyst 14.5, tvOS 15.0, watchOS 9.0, *) { |
There was a problem hiding this comment.
Is this intentionally adding macOS?
There was a problem hiding this comment.
Yes, I think I overcautiously omitted macOS when splitting this off from FirebaseAppCheck. In the original code it was #if TARGET_OS_IOS (always false in Swift). I changed it to #if os(iOS) || os(tvOS) || os(watchOS) when I forked it but the API is also available on macOS (including Catalyst) so I just dropped the os() conditionals entirely. This also allows it to work on visionOS since it falls through the * in the if #available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported the changes from firebase/firebase-ios-sdk#11662 into AppCheckCore:
GAC_DEVICE_CHECK_PROVIDER_AVAILABILITYandGAC_APP_ATTEST_PROVIDER_AVAILABILITYAPI availability macros to reflect the set of supported platforms for DeviceCheck (iOS 11+, macOS 10.15+, macCatalyst 13+, tvOS 11+, watchOS 9+) and App Attest (iOS 14+, macOS 11.3+, macCatalyst 14.5+, tvOS 15+, watchOS 9+).