Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pitch field not working with prompt #4436

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Closes #4430
Related to google/blockly-games#212

Proposed Changes

Calls getValueFromEditorText_ before passing the value to setValue from the text input prompt editor (which is used on mobile).

I also got rid of the closure and used .bind() instead, as recommended by the styleguide.

Reason for Changes

Fixing bugs :D

Test Coverage

Could not reproduce google/blockly-games#212 using the following steps:

  1. Change the text input field's show editor function to look like:
    Blockly.FieldTextInput.prototype.showEditor_ = function(_opt_e,
      opt_quietInput) {
      this.showPromptEditor_();
    };
    
  2. Locally load the pitch field demo.
  3. Enter the text "G4" into the prompt.
  4. Hit "Ok".
  5. Observe how the field has been properly updated.

Tested on:

  • Desktop Chrome

Documentation

Nope!

Additional Information

N/A

@moniika moniika merged commit 76192da into google:develop Nov 9, 2020
@BeksOmega BeksOmega deleted the fix/pitch-prompt branch May 13, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants