Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up measurement code in mini workspace bubble #7408

Merged

Conversation

rachel-fenichel
Copy link
Collaborator

The basics

The details

Resolves

Part of #7104

Proposed Changes

Stop adding extra margin to mini workspace bubbles (mutator bubbles). Make the margin the same in RTL and LTR.

Behavior Before Change

RTL:
image

LTR:
image

Behavior After Change

RTL:
image

LTR:
image

Reason for Changes

Could not find a reason for the previous inconsistency.

Test Coverage

Opened mutators in LTR and RTL modes and dragged blocks around inside the mutator bubbles to make them change size.

Documentation

None

@rachel-fenichel rachel-fenichel requested a review from a team as a code owner August 17, 2023 19:56
@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label Aug 17, 2023
@rachel-fenichel rachel-fenichel merged commit 60aa99a into google:develop Aug 17, 2023
10 of 11 checks passed
@rachel-fenichel rachel-fenichel deleted the mini_workspace_measurement branch August 17, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants