Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vi: Welcome - Running the Course translation #1949

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

khoaxuantu
Copy link
Contributor

The Vietnamese translation has been set up, so I would love to contribute. Here is the translation of Welcome to Comprehensive Rust: (1) Running the Course.

I have followed the Contributing Guidelines:

  • Edited by Poedit
  • Formatted by dprint fmt
  • Submitted to the CLA

Copy link
Collaborator

@daivinhtran daivinhtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khoaxuantu ! This is awesome. I left a few minor comments. The rest LGTM.

po/vi.po Outdated

#: src/SUMMARY.md src/index.md
msgid "Welcome to Comprehensive Rust 🦀"
msgstr "Chào mừng bạn đến với Comprehensive Rust"

#: src/SUMMARY.md src/running-the-course.md
msgid "Running the Course"
msgstr ""
msgstr "Hướng dẫn khóa học"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Capitalization.

po/vi.po Outdated

#: src/SUMMARY.md src/running-the-course/course-structure.md
msgid "Course Structure"
msgstr ""
msgstr "Cấu trúc khóa học"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Capitalization.

po/vi.po Outdated

#: src/SUMMARY.md src/running-the-course/keyboard-shortcuts.md
msgid "Keyboard Shortcuts"
msgstr ""
msgstr "Phím tắt"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Capitalization.

po/vi.po Show resolved Hide resolved
@daivinhtran
Copy link
Collaborator

Can you also leave a comment in this Assignment sheet for where you translated as well?

@khoaxuantu
Copy link
Contributor Author

Thanks @khoaxuantu ! This is awesome. I left a few minor comments. The rest LGTM.

Hi @daivinhtran ! I just have resolved your reviews. Please take a look again.

@daivinhtran daivinhtran enabled auto-merge (squash) April 2, 2024 14:05
@daivinhtran daivinhtran merged commit 0b04007 into google:main Apr 2, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants