-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vi: Welcome - Running the Course translation #1949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @khoaxuantu ! This is awesome. I left a few minor comments. The rest LGTM.
po/vi.po
Outdated
|
||
#: src/SUMMARY.md src/index.md | ||
msgid "Welcome to Comprehensive Rust 🦀" | ||
msgstr "Chào mừng bạn đến với Comprehensive Rust" | ||
|
||
#: src/SUMMARY.md src/running-the-course.md | ||
msgid "Running the Course" | ||
msgstr "" | ||
msgstr "Hướng dẫn khóa học" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Capitalization.
po/vi.po
Outdated
|
||
#: src/SUMMARY.md src/running-the-course/course-structure.md | ||
msgid "Course Structure" | ||
msgstr "" | ||
msgstr "Cấu trúc khóa học" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Capitalization.
po/vi.po
Outdated
|
||
#: src/SUMMARY.md src/running-the-course/keyboard-shortcuts.md | ||
msgid "Keyboard Shortcuts" | ||
msgstr "" | ||
msgstr "Phím tắt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Capitalization.
Can you also leave a comment in this Assignment sheet for where you translated as well? |
Hi @daivinhtran ! I just have resolved your reviews. Please take a look again. |
The Vietnamese translation has been set up, so I would love to contribute. Here is the translation of Welcome to Comprehensive Rust: (1) Running the Course.
I have followed the Contributing Guidelines:
dprint fmt