Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vi: fix renamed file scoped_threads.md #2041

Conversation

vohoanglong0107
Copy link
Contributor

After merging #2007, the file src/concurrency/scoped-threads.md was renamed into src/concurrency/threads/scoped.md, but the changes were not reflected in all translations files.

There are others file affected by #2007. I will create a dedicated PR for each of these files to make the review process easier.

@mgeisler
Copy link
Collaborator

mgeisler commented May 3, 2024

the changes were not reflected in all translations files.

The filenames in the .po file comments are only used by translators to jump to the definition in the PO editor.

You should not update it by hand: you should only update the comments and the msgid fields using msgmerge as part of a translation file refresh. See Refreshing an Existing Translation for how to do this.

@mgeisler
Copy link
Collaborator

mgeisler commented May 3, 2024

I will close this PR since there is a supported way of updating these comments.

@mgeisler mgeisler closed this May 3, 2024
@mgeisler
Copy link
Collaborator

mgeisler commented May 3, 2024

Cc @henrif75 in case you see other PRs like this. We might need to update our testing and documentation to make this clearer.

@vohoanglong0107 vohoanglong0107 deleted the fix-wrong-file-name-scoped-thread branch May 3, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants