Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise: method and traits: change output #2383

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

Alx-Lai
Copy link
Contributor

@Alx-Lai Alx-Lai commented Sep 30, 2024

In this exercise, the original StderrLogger output to stderr, which user cannot see the original log but "No output" in frontend". Change eprintln! to println! to make it see-able in the frontend. Also, due to the change, rename the logger struct.

Close: #2382

In this exercise, the original StderrLogger output to
stderr, which user cannot see the original log but
"No output" in frontend". Change `eprintln!` to `println!`
to make it see-able in the frontend. Also, due to the
change, rename the logger struct.

Signed-off-by: Alx-Lai <[email protected]>
@Alx-Lai
Copy link
Contributor Author

Alx-Lai commented Sep 30, 2024

Here's the result:

image

Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for renaming the class, too -- that's the kind of detail I'd miss :)

@djmitche djmitche enabled auto-merge (squash) September 30, 2024 15:09
@djmitche djmitche merged commit 29dcb0c into google:main Sep 30, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Exercise][13. Methods and Traits] Better output of example solution
2 participants