Wrap assembly comments consistently #2430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some lines were much longer than others. They are now consistently wrapped at 70 columns. Why so short, why not 80 or 90? Because we sometimes need to browse these files during class, and there we don’t have a lot of horizontal space when using large fonts.
| @@ -64,7 +65,9 @@ | |||
| ldr x18, [sp, #8 * 18] | |||
| ldp x29, x30, [sp, #8 * 20] | |||
|
|
|||
| /* Restore registers elr_el1 & spsr_el1, using x0 & x1 as scratch. */ | |||
| /* | |||
| * Restore registers elr_el1 & spsr_el1, using x0 & x1 as scratch. | |||
There was a problem hiding this comment.
this comment seems to have an incorrect indentation
There was a problem hiding this comment.
it looks like tabs vs. spaces
| @@ -67,7 +67,10 @@ SECTIONS | |||
| data_end = .; | |||
| } >image | |||
|
|
|||
| /* Everything beyond this point will not be included in the binary. */ | |||
| /* | |||
| * Everything beyond this point will not be included in the | |||
There was a problem hiding this comment.
incorrect indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some lines were much longer than others. They are now consistently
wrapped at 70 columns. Why so short, why not 80 or 90? Because we
sometimes need to browse these files during class, and there we don’t
have a lot of horizontal space when using large fonts.