Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vi: translate Default trait #2447

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

vi: translate Default trait #2447

wants to merge 1 commit into from

Conversation

vohoanglong0107
Copy link
Contributor

Translate the Default chapter of the std-trait section to Vietnamese

qu-ngx
qu-ngx reviewed Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@qu-ngx qu-ngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am running some tests on your PR first. I will get back to this PR later when they are done.

qu-ngx
qu-ngx reviewed Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@qu-ngx qu-ngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. Please feel free to correct me if I'm wrong anywhere:)) Tks!

po/vi.po

#: src/std-traits/default.md
msgid ""
"It can be implemented directly or it can be derived via `#[derive(Default)]`."
msgstr ""
"Người dùng có thể trực tiếp implement trait này, hoặc derive trait này bằng "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this trans holds "trait" as a type but since "implement" type isn't here for this one can we use "ứng dụng" or "áp dụng" instead? Which one do you prefer better and why?

po/vi.po

#: src/std-traits/default.md
msgid ""
"A derived implementation will produce a value where all fields are set to "
"their default values."
msgstr ""
"Khi derive trait này, từng miền của giá trị mặc định được tạo ra sẽ được gán "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"derive" will be resolved as well according to the above "implement".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu-ngx qu-ngx qu-ngx left review comments

@daivinhtran daivinhtran Awaiting requested review from daivinhtran daivinhtran is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
translation/vi translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vohoanglong0107 @qu-ngx