Skip to content

Commit

Permalink
[Vulkan] Allow internal errors when calling GetAHardwareBufferProperties
Browse files Browse the repository at this point in the history
This method makes a Vulkan API call that will return an error if
`handle` is invalid. This is not cause to lose the Dawn device, as it is
a client-side error and not a true internal Dawn error (see [1] for
fuller analysis).

[1] https://issues.chromium.org/u/1/issues/346282342#comment20

Change-Id: Id0abb3f44e4abc369c59bc8a330c425b8317c4ea
Bug: 346282342
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/213274
Commit-Queue: Colin Blundell <[email protected]>
Auto-Submit: Colin Blundell <[email protected]>
Reviewed-by: Corentin Wallez <[email protected]>
  • Loading branch information
colinblundell authored and Dawn LUCI CQ committed Nov 4, 2024
1 parent b1a84c7 commit 2c4f822
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/dawn/native/Device.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1948,7 +1948,11 @@ wgpu::Status DeviceBase::APIGetAHardwareBufferProperties(void* handle,
return wgpu::Status::Error;
}

if (ConsumedError(GetAHardwareBufferPropertiesImpl(handle, properties))) {
// This method makes a Vulkan API call that will return an error if `handle` is invalid. This
// is not cause to lose the Dawn device, as it is a client-side error and not a true internal
// Dawn error.
if (ConsumedError(GetAHardwareBufferPropertiesImpl(handle, properties),
InternalErrorType::Internal)) {
return wgpu::Status::Error;
}

Expand Down

0 comments on commit 2c4f822

Please sign in to comment.