Skip to content

Commit

Permalink
Run Flogger tests under JDK 22 instead of JDK 15.
Browse files Browse the repository at this point in the history
I assume that our goal here was to use the latest STS.

We could also consider adding JDK 21 (as the latest LTS), and we could consider removing 11 (to keep 8 and 21 as LTS "endpoints"). I doubt it's worth thinking too hard about, but at least the bump from 15 to 22 seems uncontroversial. Hopefully it passes tests :)

As usual, we'll want to mess with the names of the CI jobs in [the branch-protection rules](https://github.com/google/flogger/settings/branches). I think that post-submission should be OK, since I'm not sure Copybara cares about the rules, but we'll see. (We could in theory avoid that by picking consistent names instead of version numbers (e.g., "oldest LTS," "newest LTS," "newest STS"), but _shrug_.)

RELNOTES=n/a
PiperOrigin-RevId: 662927095
  • Loading branch information
cpovirk authored and Flogger Team committed Aug 15, 2024
1 parent 474b113 commit 02e1ac8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
name: "JDK ${{ matrix.java }}"
strategy:
matrix:
java: [8, 11, 15]
java: [8, 11, 22]
runs-on: ubuntu-latest
steps:
# Cancel any previous runs for the same branch that are still running.
Expand Down

0 comments on commit 02e1ac8

Please sign in to comment.