-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noto Serif Dogra: Version 1.006; ttfautohint (v1.8.4.7-5d5b) added #5377
Conversation
….4.7-5d5b) added * Noto Serif Dogra Version 1.006; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/notofonts/dogra.git at commit https://github.com/notofonts/dogra/commit/.
7742b27
to
3d26193
Compare
Fontbakery reportFontbakery version: 0.8.10 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[16] NotoSerifDogra-Regular.ttf🔥 FAIL: Check for METADATA subsets with zero support. (com.google.fonts/check/metadata/unsupported_subsets)
🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours:
[code: contour-count] ⚠ WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments] ⚠ WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Note: The following loglevels were omitted in this report:
|
@simoncozens This is not happening in Chrome, only Edge and Safari |
Oh heck. I think I understand this. The font was previously built assuming that Dogra goes through the standard shaper, not the USE. But these days Harfbuzz pushes it through the USE, so I rebuilt the font to use the USE features appropriately. So now it works on Harfbuzz, but not on older shapers. This will be interesting to fix. |
This is for next year anyway. |
@simoncozens we would need to merge that PR soon so we can move forward with the language update |
See #6576 instead. |
It now also works with latest Safari. I'm happy with it. If Edge is broken, this is an Edge bug, not a font bug. |
FontBakery reportfontbakery version: 0.9.0a3 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[17] NotoSerifDogra-Regular.ttf⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check if uppercase glyphs are vertically centered. (com.google.fonts/check/caps_vertically_centered)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours:
[code: contour-count] ⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 310: ⚠ WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments] ⚠ WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
The dot of soft dotted characters should disappear in other cases, for example: ĩ ĭ i̇ ǐ i̒ ĩ̦ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ ĩ̧ ĭ̧ i̧̇ i̧̊ i̧̋ ǐ̧ i̧̒ ĵ Your font does not cover the following languages that require the soft-dotted feature: Aghem (Latn, 38,843 speakers), Basaa (Latn, 332,940 speakers), Dutch (Latn, 31,709,104 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Lithuanian (Latn, 2,357,094 speakers), Belarusian (Cyrl, 10,064,517 speakers), Igbo (Latn, 27,823,640 speakers), Navajo (Latn, 166,319 speakers). [code: soft-dotted] ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
3d26193: [gftools-packager] Noto Serif Dogra: Version 1.006; ttfautohint (v1.8.4.7-5d5b) added