Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Serif Dogra: Version 1.006; ttfautohint (v1.8.4.7-5d5b) added #5377

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

simoncozens
Copy link
Collaborator

3d26193: [gftools-packager] Noto Serif Dogra: Version 1.006; ttfautohint (v1.8.4.7-5d5b) added

….4.7-5d5b) added

* Noto Serif Dogra Version 1.006; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/notofonts/dogra.git at commit https://github.com/notofonts/dogra/commit/.
@simoncozens simoncozens force-pushed the gftools_packager_ofl_notoserifdogra branch from 7742b27 to 3d26193 Compare October 6, 2022 11:56
@gf-bot
Copy link

gf-bot commented Oct 6, 2022

Fontbakery report

Fontbakery version: 0.8.10

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[16] NotoSerifDogra-Regular.ttf
🔥 FAIL: Check for METADATA subsets with zero support. (com.google.fonts/check/metadata/unsupported_subsets)
  • 🔥 FAIL Please remove the unrecognized subset 'dogra' from the METADATA.pb file. [code: unknown-subset]
🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
  • WARN The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • Avagraha.dogra

    • Eight.dogra

    • Five.dogra

    • Four.dogra

    • Nine.dogra

    • One.dogra

    • Seven.dogra

    • Six.dogra

    • Three.dogra

    • Two.dogra

    • And 6 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: aogonek	Contours detected: 3	Expected: 2 

- And Glyph name: uogonek	Contours detected: 2	Expected: 1

[code: contour-count]

WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • comma (U+002C): X=114.0,Y=1.0 (should be at baseline 0?)

    • three (U+0033): X=334.5,Y=1.0 (should be at baseline 0?)

    • five (U+0035): X=395.5,Y=624.0 (should be at cap-height 625?)

    • nine (U+0039): X=139.0,Y=2.0 (should be at baseline 0?)

    • semicolon (U+003B): X=132.0,Y=1.0 (should be at baseline 0?)

    • G (U+0047): X=519.0,Y=1.5 (should be at baseline 0?)

    • P (U+0050): X=422.0,Y=625.5 (should be at cap-height 625?)

    • V (U+0056): X=192.0,Y=624.0 (should be at cap-height 625?)

    • V (U+0056): X=520.0,Y=623.0 (should be at cap-height 625?)

    • W (U+0057): X=201.0,Y=624.0 (should be at cap-height 625?)

    • And 49 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • WARN The following glyphs have colinear vectors:

    • Ba.dogra (U+11820): L<<326.0,385.0>--<242.0,353.0>> -> L<<242.0,353.0>--<239.0,352.0>>

    • And Rra.dogra (U+1182B): L<<311.0,70.0>--<293.0,67.0>> -> L<<293.0,67.0>--<235.0,60.0>> [code: found-colinear-vectors]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notoserifdogra/NotoSerifDogra-Regular.ttf
Dehinted Size 65.7kb
Hinted Size 93.3kb
Increase 27.6kb
Change 42.0 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.006; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • INFO No sample_glyphs on METADATA.pb [code: no-samples]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp

    • vhea

    • And vmtx [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notoserifdogra [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 2 7 54 8 156 0
0% 1% 3% 24% 4% 69% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner added - Ready for Review I Small Fix bugs fixed but nothing added labels Oct 6, 2022
@RosaWagner
Copy link
Contributor

@simoncozens This is not happening in Chrome, only Edge and Safari

Desktop_OS_X_High_Sierra_safari_11 1_

@RosaWagner RosaWagner added -- Needs confirmation from upstream or onboarder and removed - Ready for Review labels Oct 6, 2022
@simoncozens
Copy link
Collaborator Author

Oh heck. I think I understand this. The font was previously built assuming that Dogra goes through the standard shaper, not the USE. But these days Harfbuzz pushes it through the USE, so I rebuilt the font to use the USE features appropriately. So now it works on Harfbuzz, but not on older shapers.

This will be interesting to fix.

@RosaWagner RosaWagner added the -- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) label Oct 7, 2022
@simoncozens simoncozens marked this pull request as draft October 24, 2022 10:24
@simoncozens
Copy link
Collaborator Author

This is for next year anyway.

@simoncozens simoncozens self-assigned this Jun 22, 2023
This was referenced Jul 28, 2023
@RosaWagner
Copy link
Contributor

@simoncozens we would need to merge that PR soon so we can move forward with the language update

@simoncozens
Copy link
Collaborator Author

See #6576 instead.

@RosaWagner RosaWagner mentioned this pull request Sep 7, 2023
29 tasks
@simoncozens
Copy link
Collaborator Author

So now it works on Harfbuzz, but not on older shapers.

It now also works with latest Safari. I'm happy with it. If Edge is broken, this is an Edge bug, not a font bug.

@simoncozens simoncozens removed -- Needs confirmation from upstream or onboarder I Small Fix bugs fixed but nothing added -- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) labels Sep 8, 2023
@simoncozens simoncozens marked this pull request as ready for review September 8, 2023 07:34
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

FontBakery report

fontbakery version: 0.9.0a3

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[17] NotoSerifDogra-Regular.ttf
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, tifinagh, coptic, math

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+0307 COMBINING DOT ABOVE: try adding one of: syriac, old-permic, tai-le, coptic, math, malayalam, tifinagh, canadian-aboriginal

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage

  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le

Or you can add the above codepoints to one of the subsets supported by the font: dogra, latin, latin-ext, menu [code: unreachable-subsetting]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
  • WARN The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check if uppercase glyphs are vertically centered. (com.google.fonts/check/caps_vertically_centered)
  • WARN Uppercase glyphs are not vertically centered in the em box. [code: vertical-metrics-not-centered]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • Avagraha.dogra

    • Eight.dogra

    • Five.dogra

    • Four.dogra

    • Nine.dogra

    • One.dogra

    • Seven.dogra

    • Six.dogra

    • Three.dogra

    • Two.dogra

    • 6 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: uogonek	Contours detected: 2	Expected: 1

[code: contour-count]

WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 559 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 310:
minus
[code: width-outliers]

WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • comma (U+002C): X=114.0,Y=1.0 (should be at baseline 0?)

    • three (U+0033): X=334.5,Y=1.0 (should be at baseline 0?)

    • five (U+0035): X=395.5,Y=624.0 (should be at cap-height 625?)

    • nine (U+0039): X=139.0,Y=2.0 (should be at baseline 0?)

    • semicolon (U+003B): X=132.0,Y=1.0 (should be at baseline 0?)

    • G (U+0047): X=519.0,Y=1.5 (should be at baseline 0?)

    • P (U+0050): X=422.0,Y=625.5 (should be at cap-height 625?)

    • V (U+0056): X=192.0,Y=624.0 (should be at cap-height 625?)

    • V (U+0056): X=520.0,Y=623.0 (should be at cap-height 625?)

    • W (U+0057): X=201.0,Y=624.0 (should be at cap-height 625?)

    • 49 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • WARN The following glyphs have colinear vectors:

    • Ba.dogra (U+11820): L<<326.0,385.0>--<242.0,353.0>> -> L<<242.0,353.0>--<239.0,352.0>>

    • Rra.dogra (U+1182B): L<<311.0,70.0>--<293.0,67.0>> -> L<<293.0,67.0>--<235.0,60.0>> [code: found-colinear-vectors]

WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: ĩ ĭ i̇ ǐ i̒ ĩ̦ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ ĩ̧ ĭ̧ i̧̇ i̧̊ i̧̋ ǐ̧ i̧̒ ĵ

Your font does not cover the following languages that require the soft-dotted feature: Aghem (Latn, 38,843 speakers), Basaa (Latn, 332,940 speakers), Dutch (Latn, 31,709,104 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Lithuanian (Latn, 2,357,094 speakers), Belarusian (Cyrl, 10,064,517 speakers), Igbo (Latn, 27,823,640 speakers), Navajo (Latn, 166,319 speakers). [code: soft-dotted]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notoserifdogra/NotoSerifDogra-Regular.ttf
Dehinted Size 65.7kb
Hinted Size 93.3kb
Increase 27.6kb
Change 42.0 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.006; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp

    • vhea

    • vmtx [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notoserifdogra [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 11 63 7 168 0
0% 0% 4% 25% 3% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner merged commit b2487b2 into main Sep 8, 2023
9 checks passed
@RosaWagner RosaWagner deleted the gftools_packager_ofl_notoserifdogra branch September 8, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

3 participants