Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Serif Old Uyghur: Version 1.002; ttfautohint (v1.8.4.7-5d5b) added #5395

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

simoncozens
Copy link
Collaborator

871972c: [gftools-packager] Noto Serif Old Uyghur: Version 1.002; ttfautohint (v1.8.4.7-5d5b) added

@gf-bot
Copy link

gf-bot commented Oct 11, 2022

Fontbakery report

Fontbakery version: 0.8.10

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[17] NotoSerifOldUyghur-Regular.ttf
🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)
  • WARN Family not found via Google Fonts API. [code: not-found]
WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
  • WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
    FONT_FAMILY_NAME = 'Noto Serif Old Uyghur' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • sadheuyg.alt
      [code: unreachable-glyphs]
WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: aogonek	Contours detected: 3	Expected: 2 

- And Glyph name: uogonek	Contours detected: 2	Expected: 1

[code: contour-count]

WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
  • WARN The following mark characters could be in the GDEF mark glyph class:
    dotaboveuyg (U+10F82), dotbelowuyg (U+10F83), twodotsaboveuyg (U+10F84) and twodotsbelowuyg (U+10F85) [code: mark-chars]
WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • comma (U+002C): X=114.0,Y=1.0 (should be at baseline 0?)

    • comma (U+002C): X=114.0,Y=1.0 (should be at cap-height 0?)

    • three (U+0033): X=334.5,Y=1.0 (should be at baseline 0?)

    • three (U+0033): X=334.5,Y=1.0 (should be at cap-height 0?)

    • nine (U+0039): X=139.0,Y=2.0 (should be at baseline 0?)

    • nine (U+0039): X=139.0,Y=2.0 (should be at cap-height 0?)

    • semicolon (U+003B): X=132.0,Y=1.0 (should be at baseline 0?)

    • semicolon (U+003B): X=132.0,Y=1.0 (should be at cap-height 0?)

    • G (U+0047): X=519.0,Y=1.5 (should be at baseline 0?)

    • G (U+0047): X=519.0,Y=1.5 (should be at cap-height 0?)

    • And 48 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notoserifolduyghur/NotoSerifOldUyghur-Regular.ttf
Dehinted Size 54.2kb
Hinted Size 77.6kb
Increase 23.4kb
Change 43.1 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.002; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • INFO No sample_glyphs on METADATA.pb [code: no-samples]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • And gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notoserifolduyghur [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 9 58 8 151 0
0% 0% 4% 26% 4% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@simoncozens simoncozens marked this pull request as draft October 11, 2022 19:59
@simoncozens simoncozens marked this pull request as ready for review January 11, 2023 10:12
@simoncozens simoncozens force-pushed the gftools_packager_ofl_notoserifolduyghur branch from 871972c to cab412a Compare January 11, 2023 10:34
@simoncozens simoncozens added this to the 2023 Q2 milestone Feb 28, 2023
@RosaWagner RosaWagner added -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required -- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) labels Apr 19, 2023
@simoncozens simoncozens self-assigned this Jun 22, 2023
@RosaWagner RosaWagner removed this from the 2023 Q2 milestone Jul 19, 2023
@RosaWagner
Copy link
Contributor

@simoncozens do we have now language data for Old Uyghur?

@simoncozens
Copy link
Collaborator Author

No, and it's going to be tricky. :-( I could try Andrew West, or we could try transliterating from another script.

@RosaWagner RosaWagner mentioned this pull request Sep 7, 2023
29 tasks
@simoncozens
Copy link
Collaborator Author

We now have sample text (just merged, but we need a new lang release).

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

FontBakery report

fontbakery version: 0.9.0a3

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[18] NotoSerifOldUyghur-Regular.ttf
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, tifinagh, yi

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, cherokee, tifinagh, math

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+0307 COMBINING DOT ABOVE: try adding one of: coptic, tai-le, old-permic, canadian-aboriginal, syriac, malayalam, math, tifinagh

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le

  • U+200C ZERO WIDTH NON-JOINER: try adding one of: mongolian, rejang, syloti-nagri, grantha, sharada, balinese, malayalam, khmer, siddham, tai-tham, warang-citi, telugu, new-tai-lue, devanagari, tibetan, tifinagh, hanunoo, saurashtra, brahmi, gunjala-gondi, duployan, hanifi-rohingya, hatran, kannada, pahawh-hmong, tirhuta, syriac, cham, buginese, chakma, batak, takri, yi, mahajani, sogdian, sinhala, tamil, gurmukhi, sundanese, kharoshthi, limbu, bengali, newa, tai-viet, myanmar, avestan, nko, buhid, javanese, lepcha, thai, tagbanwa, psalter-pahlavi, dogra, thaana, manichaean, phags-pa, tai-le, tagalog, khojki, oriya, gujarati, meetei-mayek, mandaic, khudawadi, kaithi, kayah-li, modi

  • U+25CC DOTTED CIRCLE: try adding one of: rejang, grantha, hebrew, tibetan, tifinagh, hanunoo, buginese, mahajani, sogdian, math, limbu, buhid, thai, bassa-vah, manichaean, tai-le, caucasian-albanian, elbasan, khojki, osage, meetei-mayek, kayah-li, balinese, telugu, duployan, hanifi-rohingya, mende-kikakui, syriac, chakma, music, sinhala, tai-viet, javanese, lepcha, tagbanwa, dogra, ahom, oriya, lao, mandaic, khudawadi, sharada, symbols, malayalam, khmer, devanagari, coptic, brahmi, gunjala-gondi, kannada, pahawh-hmong, tirhuta, masaram-gondi, yi, zanabazar-square, wancho, tamil, sundanese, newa, bengali, nko, bhaiksuki, psalter-pahlavi, thaana, phags-pa, kaithi, modi, mongolian, marchen, syloti-nagri, siddham, new-tai-lue, soyombo, adlam, cham, batak, takri, old-permic, gurmukhi, kharoshthi, miao, myanmar, tagalog, gujarati

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, old-uyghur [code: unreachable-subsetting]

WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
  • WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
    FONT_FAMILY_NAME = 'Noto Serif Old Uyghur' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • WARN Aparently there's no sample strings for 'oui_Uygh' in the gflanguages package. [code: no-sample-string]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • sadheuyg.alt
      [code: unreachable-glyphs]
WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: uogonek	Contours detected: 2	Expected: 1

[code: contour-count]

WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 559 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 310:
minus
[code: width-outliers]

WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
  • WARN The following mark characters could be in the GDEF mark glyph class:
    dotaboveuyg (U+10F82), dotbelowuyg (U+10F83), twodotsaboveuyg (U+10F84) and twodotsbelowuyg (U+10F85) [code: mark-chars]
WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • comma (U+002C): X=114.0,Y=1.0 (should be at baseline 0?)

    • comma (U+002C): X=114.0,Y=1.0 (should be at cap-height 0?)

    • three (U+0033): X=334.5,Y=1.0 (should be at baseline 0?)

    • three (U+0033): X=334.5,Y=1.0 (should be at cap-height 0?)

    • nine (U+0039): X=139.0,Y=2.0 (should be at baseline 0?)

    • nine (U+0039): X=139.0,Y=2.0 (should be at cap-height 0?)

    • semicolon (U+003B): X=132.0,Y=1.0 (should be at baseline 0?)

    • semicolon (U+003B): X=132.0,Y=1.0 (should be at cap-height 0?)

    • G (U+0047): X=519.0,Y=1.5 (should be at baseline 0?)

    • G (U+0047): X=519.0,Y=1.5 (should be at cap-height 0?)

    • 48 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: ĩ ĭ i̇ ǐ i̒ ĩ̦ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ ĩ̧ ĭ̧ i̧̇ i̧̊ i̧̋ ǐ̧ i̧̒ ĵ

Your font does not cover the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Aghem (Latn, 38,843 speakers), Lithuanian (Latn, 2,357,094 speakers), Navajo (Latn, 166,319 speakers), Basaa (Latn, 332,940 speakers), Igbo (Latn, 27,823,640 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ukrainian (Cyrl, 29,273,587 speakers). [code: soft-dotted]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notoserifolduyghur/NotoSerifOldUyghur-Regular.ttf
Dehinted Size 54.2kb
Hinted Size 77.6kb
Increase 23.4kb
Change 43.1 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.002; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notoserifolduyghur [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 12 67 7 163 0
0% 0% 5% 27% 3% 65% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@simoncozens simoncozens removed the -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required label Sep 8, 2023
…(v1.8.4.7-5d5b) added

* Noto Serif Old Uyghur Version 1.003; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/notofonts/old-uyghur.git at commit https://github.com/notofonts/old-uyghur/commit/.
@simoncozens
Copy link
Collaborator Author

Updated

Noto Serif Old Uyghur: Version 1.003; ttfautohint (v1.8.4.7-5d5b) added


a1bf7e2: [gftools-packager] Noto Serif Old Uyghur: Version 1.003; ttfautohint (v1.8.4.7-5d5b) added

@simoncozens simoncozens force-pushed the gftools_packager_ofl_notoserifolduyghur branch from 1ee5d6c to a1bf7e2 Compare September 26, 2023 07:00
@github-actions
Copy link

FontBakery report

fontbakery version: 0.9.2

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[17] NotoSerifOldUyghur-Regular.ttf
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, tifinagh, yi

  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, cherokee, tifinagh, math

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+0307 COMBINING DOT ABOVE: try adding one of: coptic, syriac, canadian-aboriginal, old-permic, tai-le, math, tifinagh, malayalam

  • U+030A COMBINING RING ABOVE: try adding syriac
    8 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, old-uyghur [code: unreachable-subsetting]

WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
  • WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
    FONT_FAMILY_NAME = 'Noto Serif Old Uyghur' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • finalHethdotaboveuyg

    • finalHethdotaboveuyg.fina

    • finalHethtwodotsaboveuyg

    • finalHethtwodotsaboveuyg.fina

    • gimelHethdotaboveuyg

    • gimelHethdotaboveuyg.fina

    • gimelHethdotaboveuyg.init

    • gimelHethdotaboveuyg.medi

    • gimelHethtwodotsaboveuyg

    • gimelHethtwodotsaboveuyg.fina

    • 15 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: uogonek	Contours detected: 2	Expected: 1

[code: contour-count]

WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 559 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 310:
minus
[code: width-outliers]

WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
  • WARN The following mark characters could be in the GDEF mark glyph class:
    dotaboveuyg (U+10F82), dotbelowuyg (U+10F83), twodotsaboveuyg (U+10F84) and twodotsbelowuyg (U+10F85) [code: mark-chars]
WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • comma (U+002C): X=114.0,Y=1.0 (should be at baseline 0?)

    • comma (U+002C): X=114.0,Y=1.0 (should be at cap-height 0?)

    • three (U+0033): X=334.5,Y=1.0 (should be at baseline 0?)

    • three (U+0033): X=334.5,Y=1.0 (should be at cap-height 0?)

    • nine (U+0039): X=139.0,Y=2.0 (should be at baseline 0?)

    • nine (U+0039): X=139.0,Y=2.0 (should be at cap-height 0?)

    • semicolon (U+003B): X=132.0,Y=1.0 (should be at baseline 0?)

    • semicolon (U+003B): X=132.0,Y=1.0 (should be at cap-height 0?)

    • G (U+0047): X=519.0,Y=1.5 (should be at baseline 0?)

    • G (U+0047): X=519.0,Y=1.5 (should be at cap-height 0?)

    • 48 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Ukrainian (Cyrl, 29,273,587 speakers), Navajo (Latn, 166,319 speakers), Aghem (Latn, 38,843 speakers), Igbo (Latn, 27,823,640 speakers), Belarusian (Cyrl, 10,064,517 speakers), Basaa (Latn, 332,940 speakers). [code: soft-dotted]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notoserifolduyghur/NotoSerifOldUyghur-Regular.ttf
Dehinted Size 55.1kb
Hinted Size 78.9kb
Increase 23.8kb
Change 43.2 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.003; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notoserifolduyghur [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 11 67 7 164 0
0% 0% 4% 27% 3% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner removed the -- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) label Sep 26, 2023
@github-actions
Copy link

FontBakery report

fontbakery version: 0.9.2

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[17] NotoSerifOldUyghur-Regular.ttf
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, yi, tifinagh

  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, math, coptic, tifinagh

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+0307 COMBINING DOT ABOVE: try adding one of: coptic, old-permic, syriac, tai-le, math, malayalam, tifinagh, canadian-aboriginal

  • U+030A COMBINING RING ABOVE: try adding syriac
    8 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, old-uyghur [code: unreachable-subsetting]

WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
  • WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
    FONT_FAMILY_NAME = 'Noto Serif Old Uyghur' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • finalHethdotaboveuyg

    • finalHethdotaboveuyg.fina

    • finalHethtwodotsaboveuyg

    • finalHethtwodotsaboveuyg.fina

    • gimelHethdotaboveuyg

    • gimelHethdotaboveuyg.fina

    • gimelHethdotaboveuyg.init

    • gimelHethdotaboveuyg.medi

    • gimelHethtwodotsaboveuyg

    • gimelHethtwodotsaboveuyg.fina

    • 15 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: uogonek	Contours detected: 2	Expected: 1

[code: contour-count]

WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 559 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 310:
minus
[code: width-outliers]

WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
  • WARN The following mark characters could be in the GDEF mark glyph class:
    dotaboveuyg (U+10F82), dotbelowuyg (U+10F83), twodotsaboveuyg (U+10F84) and twodotsbelowuyg (U+10F85) [code: mark-chars]
WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • comma (U+002C): X=114.0,Y=1.0 (should be at baseline 0?)

    • comma (U+002C): X=114.0,Y=1.0 (should be at cap-height 0?)

    • three (U+0033): X=334.5,Y=1.0 (should be at baseline 0?)

    • three (U+0033): X=334.5,Y=1.0 (should be at cap-height 0?)

    • nine (U+0039): X=139.0,Y=2.0 (should be at baseline 0?)

    • nine (U+0039): X=139.0,Y=2.0 (should be at cap-height 0?)

    • semicolon (U+003B): X=132.0,Y=1.0 (should be at baseline 0?)

    • semicolon (U+003B): X=132.0,Y=1.0 (should be at cap-height 0?)

    • G (U+0047): X=519.0,Y=1.5 (should be at baseline 0?)

    • G (U+0047): X=519.0,Y=1.5 (should be at cap-height 0?)

    • 48 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Igbo (Latn, 27,823,640 speakers), Ejagham (Latn, 120,000 speakers), Navajo (Latn, 166,319 speakers), Dan (Latn, 1,099,244 speakers), Ebira (Latn, 2,200,000 speakers), Ma’di (Latn, 584,000 speakers), Dutch (Latn, 31,709,104 speakers), Koonzime (Latn, 40,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Avokaya (Latn, 100,000 speakers), Kom (Latn, 360,685 speakers), Basaa (Latn, 332,940 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Nateni (Latn, 100,000 speakers), Lugbara (Latn, 2,200,000 speakers), Aghem (Latn, 38,843 speakers). [code: soft-dotted]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notoserifolduyghur/NotoSerifOldUyghur-Regular.ttf
Dehinted Size 55.1kb
Hinted Size 78.9kb
Increase 23.8kb
Change 43.2 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.003; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notoserifolduyghur [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 11 67 7 164 0
0% 0% 4% 27% 3% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner merged commit 01eed2e into main Sep 27, 2023
9 checks passed
@RosaWagner RosaWagner deleted the gftools_packager_ofl_notoserifolduyghur branch September 27, 2023 12:17
@simoncozens simoncozens mentioned this pull request Oct 4, 2023
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

3 participants