-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noto Serif JP: Version 2.001-H2 added #6020
Conversation
Fontbakery reportFontbakery version: 0.8.11 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[33] NotoSerifJP[wght].ttf🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints] 🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
"copyright 2014-2021 adobe (http://www.adobe.com/), with reserved font name 'source'" which does not match the expected format, similar to: "Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format] 🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)
🔥 FAIL: METADATA.pb font.name value should be same as the family name declared on the name table. (com.google.fonts/check/metadata/nameid/font_name)
🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)
But font copyright string has: http://www.adobe.com/ 🔥 FAIL: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ? (com.google.fonts/check/metadata/nameid/copyright)
🔥 FAIL: Check font follows the Google Fonts CJK vertical metric schema (com.google.fonts/check/cjk_vertical_metrics)
🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
⚠ WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'. (com.google.fonts/check/metadata/reserved_font_name)
⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long] ⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
⚠ WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)
⚠ WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 571: ⚠ WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)
⚠ WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
|
38890ef
to
5747035
Compare
Fontbakery reportFontbakery version: 0.8.11 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[32] NotoSerifJP[wght].ttf🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints] 🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
"copyright 2014-2021 adobe (http://www.adobe.com/), with reserved font name 'source'" which does not match the expected format, similar to: "Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format] 🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)
🔥 FAIL: METADATA.pb font.name value should be same as the family name declared on the name table. (com.google.fonts/check/metadata/nameid/font_name)
🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)
But font copyright string has: http://www.adobe.com/ 🔥 FAIL: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ? (com.google.fonts/check/metadata/nameid/copyright)
🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
⚠ WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'. (com.google.fonts/check/metadata/reserved_font_name)
⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long] ⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
⚠ WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)
⚠ WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 571: ⚠ WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)
⚠ WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
Fontbakery reportFontbakery version: 0.8.11 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[32] NotoSerifJP[wght].ttf🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints] 🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
"copyright 2014-2021 adobe (http://www.adobe.com/), with reserved font name 'source'" which does not match the expected format, similar to: "Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format] 🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)
🔥 FAIL: METADATA.pb font.name value should be same as the family name declared on the name table. (com.google.fonts/check/metadata/nameid/font_name)
🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)
But font copyright string has: http://www.adobe.com/ 🔥 FAIL: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ? (com.google.fonts/check/metadata/nameid/copyright)
🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
⚠ WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'. (com.google.fonts/check/metadata/reserved_font_name)
⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long] ⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
⚠ WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)
⚠ WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 571: ⚠ WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)
⚠ WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
Fontbakery reportFontbakery version: 0.8.11 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[32] NotoSerifJP[wght].ttf🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints] 🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
"copyright 2014-2021 adobe (http://www.adobe.com/), with reserved font name 'source'" which does not match the expected format, similar to: "Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format] 🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)
🔥 FAIL: METADATA.pb font.name value should be same as the family name declared on the name table. (com.google.fonts/check/metadata/nameid/font_name)
🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)
But font copyright string has: http://www.adobe.com/ 🔥 FAIL: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ? (com.google.fonts/check/metadata/nameid/copyright)
🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
⚠ WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'. (com.google.fonts/check/metadata/reserved_font_name)
⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long] ⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
⚠ WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)
⚠ WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 571: ⚠ WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)
⚠ WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are slight glyph changes which appear to be ok when skimming. However, judging 65k glyphs is insane. I'm wondering if we can do something we OCR to help assist us. I wouldn't mind exploring this at some point. |
@simoncozens the screenshots were taken from mac OS X. I've noticed this fading problem when a glyph has duplicate outlines or the curve direction is wrong. |
@simoncozens I'm curious, has the Latin, Greek and Cyrillic been taken from #4956? Shall we also send this back to Adobe so they can fix the color? |
No, I don't think they would use Noto for this; the upstream is Source Han Serif, which uses Source Serif as its LGC.
We can raise an issue with them, certainly. I'd check with @chrissimpkins before working out whether to delay because of this; I'm not totally aware where the desire to upgrade Noto Serif CJK came from and if there's any urgency to it. |
|
|
No description provided.