Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Serif KR: Version 2.001-H2 added #6021

Closed
wants to merge 1 commit into from
Closed

Conversation

simoncozens
Copy link
Collaborator

No description provided.

@simoncozens simoncozens added II CJK Chinese, Japanese, Korean scripts - Ready for Review I Font Upgrade labels Mar 14, 2023
@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.11

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[30] NotoSerifKR[wght].ttf
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x0308 (COMBINING DIAERESIS)

    • 0x030B (COMBINING DOUBLE ACUTE ACCENT)

    • 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)

    • 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)

    • 0x010C (LATIN CAPITAL LETTER C WITH CARON)

    • 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)

    • 0x010E (LATIN CAPITAL LETTER D WITH CARON)

    • 0x0116 (LATIN CAPITAL LETTER E WITH DOT ABOVE)

    • 0x0118 (LATIN CAPITAL LETTER E WITH OGONEK)

    • 0x011E (LATIN CAPITAL LETTER G WITH BREVE)

    • 93 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
  • 🔥 FAIL First line in license file is:

"copyright 2014-2021 adobe (http://www.adobe.com/), with reserved font name 'source'"

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]

🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)
  • 🔥 FAIL Font file is 22.7Mb, larger than limit 9.0Mb [code: massive-font]
🔥 FAIL: METADATA.pb font.name value should be same as the family name declared on the name table. (com.google.fonts/check/metadata/nameid/font_name)
  • 🔥 FAIL Unmatched familyname in font: TTF has familyname = "Noto Serif KR ExtraLight" while METADATA.pb has font.name = "Noto Serif KR". [code: mismatch]
🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)
  • 🔥 FAIL METADATA.pb font.name field ("Noto Serif KR") does not match correct font name format ("Noto Serif KR ExtraLight"). [code: mismatch]
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
  • 🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
    "Copyright 2020 The Familyname Project Authors (git url)"
    But instead we have got:
    "(c) 2017-2022 adobe (http://www.adobe.com/)." [code: bad-notice-format]
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
    But instead we have got:
    "(c) 2017-2022 Adobe (http://www.adobe.com/)." [code: bad-notice-format]
🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)
  • 🔥 FAIL Value of repository_url field is

But font copyright string has: http://www.adobe.com/
[code: mismatch]

🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • 🔥 FAIL The following glyphs could not be attached to the dotted circle glyph:

    • acutecomb

    • gravecomb

    • uni0307

    • uni030C [code: unattached-dotted-circle-marks]

WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • i + l [code: lacks-kern-info]

WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
  • WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
    FONT_FAMILY_NAME = 'Noto Serif KR ExtraLight' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • glyph00859

    • glyph01262

    • glyph01921

    • glyph01923

    • glyph01925

    • glyph01926

    • glyph01931

    • glyph01939

    • glyph01941

    • glyph01944

    • 75 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)
WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
  • WARN Interpolation issues were found in the font: - Contour 2 start point differs in glyph 'uni2299' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fcfb12d7100> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fcfb12d6ec0> [code: interpolation-issues]
WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 1000 among a set of 43 math glyphs.
    The following math glyphs have a different width, though:

Width = 571:
plus, less, greater, equal, minus, logicalnot
[code: width-outliers]

WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)
  • WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]
WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
  • WARN The following mark characters could be in the GDEF mark glyph class:
    uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C), uni302D (U+302D), uni3099 (U+3099) and uni309A (U+309A) [code: mark-chars]
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notoserifkr/NotoSerifKR[wght].ttf
Dehinted Size 22.7Mb
Hinted Size 22.7Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.001-H2;hotconv 1.1.0;makeotfexe 2.6.0'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.001-H2;hotconv 1.1.0;makeotfexe 2.6.0"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • BASE

    • GPOS

    • GSUB

    • gasp

    • vhea

    • vmtx [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notoserifkr [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 10 13 48 8 163 0
0% 4% 5% 20% 3% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@simoncozens
Copy link
Collaborator Author

Here is the diffbrowsers output. New spacing in the Latin looks like an improvement, and Hangul spacing looks better. However, we are also seeing the contour direction problems in the Japanese hiragana - this will be true for all Noto Serif CJK fonts. Again, depending on priority we should wait for a new upstream release.

notoserifkr-diff.zip

@simoncozens simoncozens linked an issue Mar 23, 2023 that may be closed by this pull request
@RosaWagner RosaWagner added -- Upstream is working on it Designer is making changes in the upstream repo and removed - Ready for Review labels Mar 29, 2023
Marjoss

This comment was marked as spam.

@RosaWagner RosaWagner removed the -- Upstream is working on it Designer is making changes in the upstream repo label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Font Upgrade II CJK Chinese, Japanese, Korean scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Noto Serif CJK fonts to variable (summary)
3 participants