Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Young Serif: Version 3.002; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33.dev8+g029e19f] added #6561

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

emmamarichal
Copy link
Collaborator

e276c34: [gftools-packager] Young Serif: Version 3.002; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33.dev8+g029e19f] added

da2d89a: Description added

@emmamarichal emmamarichal linked an issue Jul 26, 2023 that may be closed by this pull request
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@RosaWagner
Copy link
Contributor

@emmamarichal
🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)
🔥 FAIL Value of repository_url field is https://github.com/noirblancrouge/YoungSerif
But font copyright string has: https://github.com//noirblancrouge
[code: mismatch]

The copyright string in font info needs to be corrected.

@RosaWagner RosaWagner added -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required -- Needs Upstream Resolution Upstream fix required before moving forward and removed -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required labels Jul 27, 2023
@emmamarichal
Copy link
Collaborator Author

@RosaWagner Thank you, I just corrected and sent to the author
I thought fontbakery would have a check for this kind of error! (the double slash and the incomplete URL).

@emmamarichal
Copy link
Collaborator Author

Updated

Young Serif: Version 3.002; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33] added


303dadc: [gftools-packager] Young Serif: Version 3.002; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33] added

9dead3e: Description added

@emmamarichal emmamarichal force-pushed the gftools_packager_ofl_youngserif branch from da2d89a to 9dead3e Compare July 28, 2023 08:13
@emmamarichal emmamarichal removed the -- Needs Upstream Resolution Upstream fix required before moving forward label Jul 28, 2023
@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.13

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[19] YoungSerif-Regular.ttf
WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • WARN GF_TransLatin_Arabic is almost fulfilled. Missing codepoints:

    • 0x02BC (MODIFIER LETTER APOSTROPHE)

    • 0x1E34 (LATIN CAPITAL LETTER K WITH LINE BELOW)

    • 0x1E35 (LATIN SMALL LETTER K WITH LINE BELOW)

    • 0x1E96 (LATIN SMALL LETTER H WITH LINE BELOW)

    • 0x02BD (MODIFIER LETTER REVERSED COMMA)
      [code: missing-codepoints]

WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, canadian-aboriginal, tifinagh

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: math, tifinagh, coptic, cherokee

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+0307 COMBINING DOT ABOVE: try adding one of: malayalam, tifinagh, tai-le, math, coptic, canadian-aboriginal, old-permic, syriac

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
    65 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu [code: unreachable-subsetting]

WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • i + l [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Bastien Sozeau is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • IJacute

    • eight.subs

    • five.subs

    • four.subs

    • ijacute

    • nine.subs

    • one.subs

    • prime

    • seven.subs

    • six.subs

    • 3 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: eogonek	Contours detected: 3	Expected: 2

- Glyph name: Tbar	Contours detected: 2	Expected: 1

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: uni01EA	Contours detected: 3	Expected: 2

- Glyph name: uni01EB	Contours detected: 3	Expected: 2

- Glyph name: uni1E08	Contours detected: 3	Expected: 2

- Glyph name: uni1E09	Contours detected: 3	Expected: 2

- Glyph name: uni1E1C	Contours detected: 3	Expected: 2 

- 10 more.

Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • WARN The following glyphs have colinear vectors:

    • uni2206 (U+2206): L<<300.0,474.0>--<296.0,463.0>> -> L<<296.0,463.0>--<178.0,154.0>>

    • uni2206 (U+2206): L<<422.0,151.0>--<304.0,463.0>> -> L<<304.0,463.0>--<300.0,474.0>> [code: found-colinear-vectors]

WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
  • WARN The following glyphs have jaggy segments:

    • a (U+0061): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • aacute (U+00E1): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • abreve (U+0103): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • acircumflex (U+00E2): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • adieresis (U+00E4): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • ae (U+00E6): L<<393.0,-10.0>--<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 13.991741900554299

    • aeacute (U+01FD): L<<393.0,-10.0>--<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 13.991741900554299

    • agrave (U+00E0): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • amacron (U+0101): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • aogonek (U+0105): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • 11 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/youngserif/YoungSerif-Regular.ttf
Dehinted Size 76.8kb
Hinted Size 103.7kb
Increase 27.0kb
Change 35.1 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 3.002; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/youngserif [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 12 63 8 163 0
0% 0% 5% 26% 3% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner
Copy link
Contributor

Problem of design of oslash and Ldot

Screenshot 2023-07-28 at 13 59 05 Screenshot 2023-07-28 at 13 59 43 Screenshot 2023-07-28 at 14 02 31

Kerning issues

Screenshot 2023-07-28 at 14 03 19 Screenshot 2023-07-28 at 14 02 48 Screenshot 2023-07-28 at 14 02 40

@RosaWagner RosaWagner added the -- Needs Upstream Resolution Upstream fix required before moving forward label Jul 28, 2023
…5d5b);gftools[0.9.33] added

* Young Serif Version 3.003; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33] taken from the upstream repo https://github.com/noirblancrouge/YoungSerif at commit noirblancrouge/YoungSerif@8d67638.
@emmamarichal
Copy link
Collaborator Author

Updated

Young Serif: Version 3.003; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33] added


447b809: [gftools-packager] Young Serif: Version 3.003; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33] added

7254945: description and metadata

84e7ac4: metadatas

@emmamarichal emmamarichal force-pushed the gftools_packager_ofl_youngserif branch from 9dead3e to 84e7ac4 Compare August 30, 2023 14:42
@emmamarichal
Copy link
Collaborator Author

@RosaWagner updated! :)

@emmamarichal emmamarichal removed the -- Needs Upstream Resolution Upstream fix required before moving forward label Aug 30, 2023
@github-actions
Copy link

FontBakery report

fontbakery version: 0.9.0a2

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[19] YoungSerif-Regular.ttf
🔥 FAIL: Check METADATA.pb parse correctly. (com.google.fonts/check/metadata/parses)
  • 🔥 FAIL Family metadata at ofl/youngserif failed to parse.
    TRACEBACK:
    22:1 : Message type "google.fonts_public.FamilyProto" has no field named "stroke". [code: parsing-error]
WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • WARN GF_TransLatin_Arabic is almost fulfilled. Missing codepoints:

    • 0x02BC (MODIFIER LETTER APOSTROPHE)

    • 0x1E34 (LATIN CAPITAL LETTER K WITH LINE BELOW)

    • 0x1E35 (LATIN SMALL LETTER K WITH LINE BELOW)

    • 0x1E96 (LATIN SMALL LETTER H WITH LINE BELOW)

    • 0x02BD (MODIFIER LETTER REVERSED COMMA)
      [code: missing-codepoints]

WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • i + l [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • IJacute

    • eight.subs

    • five.subs

    • four.subs

    • ijacute

    • nine.subs

    • one.subs

    • prime

    • seven.subs

    • six.subs

    • 3 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: eogonek	Contours detected: 3	Expected: 2

- Glyph name: Tbar	Contours detected: 2	Expected: 1

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: uni01EA	Contours detected: 3	Expected: 2

- Glyph name: uni01EB	Contours detected: 3	Expected: 2

- Glyph name: uni1E08	Contours detected: 3	Expected: 2

- Glyph name: uni1E09	Contours detected: 3	Expected: 2

- Glyph name: uni1E1C	Contours detected: 3	Expected: 2

- 10 more.

Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]

WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • WARN The following glyphs have colinear vectors:

    • uni2206 (U+2206): L<<300.0,474.0>--<296.0,463.0>> -> L<<296.0,463.0>--<178.0,154.0>>

    • uni2206 (U+2206): L<<422.0,151.0>--<304.0,463.0>> -> L<<304.0,463.0>--<300.0,474.0>> [code: found-colinear-vectors]

WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
  • WARN The following glyphs have jaggy segments:

    • a (U+0061): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • aacute (U+00E1): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • abreve (U+0103): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • acircumflex (U+00E2): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • adieresis (U+00E4): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • ae (U+00E6): L<<393.0,-10.0>--<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 13.991741900554299

    • aeacute (U+01FD): L<<393.0,-10.0>--<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 13.991741900554299

    • agrave (U+00E0): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • amacron (U+0101): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • aogonek (U+0105): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • 11 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌ ị̀ ị́ ị̂ ị̃ ị̄

The dot of soft dotted characters should disappear in other cases, for example: i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ j̦̀ j̦́ j̦̃ j̦̄ j̦̆ j̦̇ j̦̈ j̦̊ j̦̋ ǰ̦ j̦̒ į̆ į̇ į̈ į̊

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Navajo (Latn, 166,319 speakers), Basaa (Latn, 332,940 speakers), Aghem (Latn, 38,843 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Lithuanian (Latn, 2,357,094 speakers), Igbo (Latn, 27,823,640 speakers). [code: soft-dotted]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/youngserif/YoungSerif-Regular.ttf
Dehinted Size 77.2kb
Hinted Size 104.1kb
Increase 26.9kb
Change 34.8 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 3.003; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/youngserif [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 11 108 8 119 0
0% 0% 4% 44% 3% 48% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

FontBakery report

fontbakery version: 0.9.0a2

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[19] YoungSerif-Regular.ttf
🔥 FAIL: Check METADATA.pb parse correctly. (com.google.fonts/check/metadata/parses)
  • 🔥 FAIL Family metadata at ofl/youngserif failed to parse.
    TRACEBACK:
    22:1 : Message type "google.fonts_public.FamilyProto" has no field named "stroke". [code: parsing-error]
WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • WARN GF_TransLatin_Arabic is almost fulfilled. Missing codepoints:

    • 0x02BC (MODIFIER LETTER APOSTROPHE)

    • 0x1E34 (LATIN CAPITAL LETTER K WITH LINE BELOW)

    • 0x1E35 (LATIN SMALL LETTER K WITH LINE BELOW)

    • 0x1E96 (LATIN SMALL LETTER H WITH LINE BELOW)

    • 0x02BD (MODIFIER LETTER REVERSED COMMA)
      [code: missing-codepoints]

WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • i + l [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • IJacute

    • eight.subs

    • five.subs

    • four.subs

    • ijacute

    • nine.subs

    • one.subs

    • prime

    • seven.subs

    • six.subs

    • 3 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: eogonek	Contours detected: 3	Expected: 2

- Glyph name: Tbar	Contours detected: 2	Expected: 1

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: uni01EA	Contours detected: 3	Expected: 2

- Glyph name: uni01EB	Contours detected: 3	Expected: 2

- Glyph name: uni1E08	Contours detected: 3	Expected: 2

- Glyph name: uni1E09	Contours detected: 3	Expected: 2

- Glyph name: uni1E1C	Contours detected: 3	Expected: 2

- 10 more.

Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]

WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • WARN The following glyphs have colinear vectors:

    • uni2206 (U+2206): L<<300.0,474.0>--<296.0,463.0>> -> L<<296.0,463.0>--<178.0,154.0>>

    • uni2206 (U+2206): L<<422.0,151.0>--<304.0,463.0>> -> L<<304.0,463.0>--<300.0,474.0>> [code: found-colinear-vectors]

WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
  • WARN The following glyphs have jaggy segments:

    • a (U+0061): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • aacute (U+00E1): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • abreve (U+0103): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • acircumflex (U+00E2): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • adieresis (U+00E4): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • ae (U+00E6): L<<393.0,-10.0>--<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 13.991741900554299

    • aeacute (U+01FD): L<<393.0,-10.0>--<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 13.991741900554299

    • agrave (U+00E0): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • amacron (U+0101): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • aogonek (U+0105): B<<399.5,45.5>-<402.0,65.0>-<404.0,79.0>>/B<<404.0,79.0>-<399.0,66.0>-<382.5,44.0>> = 12.90740867126579

    • 11 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌ ị̀ ị́ ị̂ ị̃ ị̄

The dot of soft dotted characters should disappear in other cases, for example: i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ j̦̀ j̦́ j̦̃ j̦̄ j̦̆ j̦̇ j̦̈ j̦̊ j̦̋ ǰ̦ j̦̒ į̆ į̇ į̈ į̊

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Aghem (Latn, 38,843 speakers), Lithuanian (Latn, 2,357,094 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Navajo (Latn, 166,319 speakers), Belarusian (Cyrl, 10,064,517 speakers), Igbo (Latn, 27,823,640 speakers), Basaa (Latn, 332,940 speakers). [code: soft-dotted]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/youngserif/YoungSerif-Regular.ttf
Dehinted Size 77.2kb
Hinted Size 104.1kb
Increase 26.9kb
Change 34.8 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 3.003; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/youngserif [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 11 108 8 119 0
0% 0% 4% 44% 3% 48% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner merged commit 0dc3bbd into main Sep 5, 2023
9 checks passed
@RosaWagner RosaWagner deleted the gftools_packager_ofl_youngserif branch September 5, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add YoungSerif
2 participants