Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wavefont: Version 3.004;gftools[0.9.33] added #6572

Merged
merged 5 commits into from
Jul 28, 2023

Conversation

RosaWagner
Copy link
Contributor

29b37dc: [gftools-packager] Wavefont: Version 3.004;gftools[0.9.33] added

b65a52b: Wavefont: axis registry overrides

@RosaWagner RosaWagner added the I Small Fix bugs fixed but nothing added label Jul 28, 2023
@RosaWagner
Copy link
Contributor Author

This PR unblocks #6185
We decided to distribute the weight differently; along 100-900 instead of 100-400

@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.13

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('ROND-YELA-wght', 1) [code: summary]


[19] Wavefont[ROND,YELA,wght].ttf
🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)
  • 🔥 FAIL METADATA.pb font.name field ("Wavefont") does not match correct font name format ("Wavefont Thin"). [code: mismatch]
🔥 FAIL: Validate defaults on fvar table match registered fallback names in GFAxisRegistry. (com.google.fonts/check/gf_axisregistry/fvar_axis_defaults)
  • 🔥 FAIL The defaul value ROND:100.0 is not registered as an axis fallback name on the Google Axis Registry.
    You should consider suggesting the addition of this value to the registry or adopted one of the existing fallback names for this axis:
    [name: "Default"
    value: 0.0
    ] [code: not-registered]
  • 🔥 FAIL The defaul value YELA:-100.0 is not registered as an axis fallback name on the Google Axis Registry.
    You should consider suggesting the addition of this value to the registry or adopted one of the existing fallback names for this axis:
    [name: "Default"
    value: 0.0
    ] [code: not-registered]
🔥 FAIL: Validate STAT particle names and values match the fallback names in GFAxisRegistry. (com.google.fonts/check/STAT/gf_axisregistry)
  • 🔥 FAIL Axis Value for 'ROND':'Default' is expected to be '0.0' but this font has 'Default'='100.0'. [code: bad-coordinate]
  • 🔥 FAIL Axis Value for 'YELA':'Default' is expected to be '0.0' but this font has 'Default'='-100.0'. [code: bad-coordinate]
🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent. (com.google.fonts/check/family/win_ascent_and_descent)
  • 🔥 FAIL OS/2.usWinAscent value should be equal or greater than 1270, but got 1200 instead [code: ascent]
  • 🔥 FAIL OS/2.usWinDescent value 200 is too large. It should be less than double the yMin. Current absolute yMin value is 0 [code: descent]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+0009 : try adding symbols

  • U+000A : try adding symbols

  • U+000B : try adding symbols

  • U+000C : try adding symbols

  • U+0085 : try adding symbols

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal

  • U+02CD MODIFIER LETTER LOW MACRON: try adding lisu

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
    14 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu [code: unreachable-subsetting]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Font contains '.notdef' as its first glyph? (com.google.fonts/check/mandatory_glyphs)
  • WARN Glyph '.notdef' should contain a drawing, but it is empty. [code: empty]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • cap
      [code: unreachable-glyphs]
WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
  • WARN Interpolation issues were found in the font: - Contour order differs in glyph '_32': [0, 1, 2] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965680e50>, [1, 2, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965613b20>.

    • Contour order differs in glyph '_30': [0, 1, 2] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965680e50>, [1, 2, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965613b20>.

    • Contour order differs in glyph '_59': [0, 1, 2] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965680e50>, [2, 1, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965613b20>.

    • Contour order differs in glyph '_53': [0, 1, 2] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965680e50>, [1, 2, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965613b20>.

    • Contour order differs in glyph '_79': [0, 1, 2] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965680e50>, [2, 1, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965613b20>.

    • Contour order differs in glyph '_42': [0, 1, 2] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965680e50>, [1, 2, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965613b20>.

    • Contour order differs in glyph '_48': [0, 1, 2] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965680e50>, [1, 2, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965613b20>.

    • Contour order differs in glyph '_18': [0, 1, 2] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965680e50>, [1, 2, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f19656135b0>.

    • Contour 0 start point differs in glyph '_18' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965680e50> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f19656135b0>

    • Contour order differs in glyph '_73': [0, 1, 2] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965680e50>, [2, 1, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f1965613b20>.

    • 141 more.

Use -F or --full-lists to disable shortening of long lists. [code: interpolation-issues]

WARN: Checking correctness of monospaced metadata. (com.google.fonts/check/monospace)
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/wavefont/Wavefont[ROND,YELA,wght].ttf
Dehinted Size 65.9kb
Hinted Size 66.0kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 3.004;gftools[0.9.33]'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 3.004;gftools[0.9.33]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • BASE

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/wavefont [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 4 7 51 9 175 0
0% 2% 3% 21% 4% 71% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.13

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('ROND-YELA-wght', 1) [code: summary]


[19] Wavefont[ROND,YELA,wght].ttf
🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)
  • 🔥 FAIL METADATA.pb font.name field ("Wavefont") does not match correct font name format ("Wavefont Thin"). [code: mismatch]
🔥 FAIL: Validate defaults on fvar table match registered fallback names in GFAxisRegistry. (com.google.fonts/check/gf_axisregistry/fvar_axis_defaults)
  • 🔥 FAIL The defaul value ROND:100.0 is not registered as an axis fallback name on the Google Axis Registry.
    You should consider suggesting the addition of this value to the registry or adopted one of the existing fallback names for this axis:
    [name: "Default"
    value: 0.0
    ] [code: not-registered]
  • 🔥 FAIL The defaul value YELA:-100.0 is not registered as an axis fallback name on the Google Axis Registry.
    You should consider suggesting the addition of this value to the registry or adopted one of the existing fallback names for this axis:
    [name: "Default"
    value: 0.0
    ] [code: not-registered]
🔥 FAIL: Validate STAT particle names and values match the fallback names in GFAxisRegistry. (com.google.fonts/check/STAT/gf_axisregistry)
  • 🔥 FAIL Axis Value for 'ROND':'Default' is expected to be '0.0' but this font has 'Default'='100.0'. [code: bad-coordinate]
  • 🔥 FAIL Axis Value for 'YELA':'Default' is expected to be '0.0' but this font has 'Default'='-100.0'. [code: bad-coordinate]
🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent. (com.google.fonts/check/family/win_ascent_and_descent)
  • 🔥 FAIL OS/2.usWinAscent value should be equal or greater than 1270, but got 1200 instead [code: ascent]
  • 🔥 FAIL OS/2.usWinDescent value 200 is too large. It should be less than double the yMin. Current absolute yMin value is 0 [code: descent]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+0009 : try adding symbols

  • U+000A : try adding symbols

  • U+000B : try adding symbols

  • U+000C : try adding symbols

  • U+0085 : try adding symbols

  • U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi

  • U+02CD MODIFIER LETTER LOW MACRON: try adding lisu

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
    14 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu [code: unreachable-subsetting]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Font contains '.notdef' as its first glyph? (com.google.fonts/check/mandatory_glyphs)
  • WARN Glyph '.notdef' should contain a drawing, but it is empty. [code: empty]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • cap
      [code: unreachable-glyphs]
WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
  • WARN Interpolation issues were found in the font: - Contour 0 start point differs in glyph '_7.clip' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5adde0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5ad840>

    • Contour 0 start point differs in glyph '_7.clip' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5adde0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5d5840>

    • Contour 0 start point differs in glyph '_7.clip' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5adde0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5d6bf0>

    • Contour order differs in glyph '_9': [0, 1, 2] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5adde0>, [0, 2, 1] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5d5840>.

    • Contour 0 start point differs in glyph '_9' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5adde0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5d5840>

    • Contour order differs in glyph '_16': [0, 1, 2] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5adde0>, [1, 2, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5d5840>.

    • Contour 0 start point differs in glyph '_16' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5adde0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5d5840>

    • Contour 0 start point differs in glyph '_17.clip' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5adde0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5ad840>

    • Contour 0 start point differs in glyph '_17.clip' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5adde0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5d5840>

    • Contour 0 start point differs in glyph '_17.clip' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5adde0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f0eea5d6bf0>

    • 141 more.

Use -F or --full-lists to disable shortening of long lists. [code: interpolation-issues]

WARN: Checking correctness of monospaced metadata. (com.google.fonts/check/monospace)
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/wavefont/Wavefont[ROND,YELA,wght].ttf
Dehinted Size 65.9kb
Hinted Size 66.0kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 3.004;gftools[0.9.33]'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 3.004;gftools[0.9.33]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • BASE

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/wavefont [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 4 7 51 9 175 0
0% 2% 3% 21% 4% 71% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner merged commit 3d0af93 into main Jul 28, 2023
7 checks passed
@RosaWagner RosaWagner deleted the gftools_packager_ofl_wavefont branch July 28, 2023 14:58
mihai19773010 referenced this pull request Aug 23, 2023
Update to_prod & to_sand lists for Fri Aug 17th
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Small Fix bugs fixed but nothing added
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

1 participant