-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seymour One: Version 1.100; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33] added #6598
Conversation
…5d5b);gftools[0.9.33] added * Seymour One Version 1.100; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33] taken from the upstream repo https://github.com/googlefonts/seymourFont at commit googlefonts/seymourFont@67aa8dc.
Indeed "book" as nameID 2 is a bit weird and definitely has to be corrected. The question is; will it break anything? It might. At the same time, the statistics on this font are very low… let's talk about it at the meeting later. |
I think it should be ok, Dave told me that "only psname is sensitive and the id2 name isn't used anywhere in Google systems afaik" |
That's what I needed to hear, let's go then! |
Why wasn't a fontbakery CI job run on this PR? I see that it did trigger the job on other PRs (such as at #6652) so why didn't it run here? Is it perhaps a bug in the google/fonts gh-actions workflow setup? |
Simon told me that it did actually run: but a comment was not automatically posted to this PR, so Simon is now trying to fix the bug, which seems to be on diffenator2 (or on gftools-qa). Thanks, @simoncozens! |
I'm going to be doing some tests on the CI using this PR, please excuse the comment spam. |
Fontbakery reportFontbakery version: 0.8.9 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[24] SeymourOne-Regular.ttf💔 ERROR: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
💔 ERROR: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
💔 ERROR: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
💔 ERROR: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
💔 ERROR: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
💔 ERROR: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
🔥 FAIL: Check METADATA.pb parse correctly. (com.google.fonts/check/metadata/parses)
🔥 FAIL: Version number has increased since previous release on Google Fonts? (com.google.fonts/check/version_bump)
🔥 FAIL: Check name table: POSTSCRIPT_NAME entries. (com.google.fonts/check/name/postscriptname)
⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
⚠ WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours:
[code: contour-count] ⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Note: The following loglevels were omitted in this report:
|
This report was generated by fontbakery version 0.8.9 but we should be running pre-releases, so it should've been v0.9.0a2 |
This is fine for this purpose; I'm just testing |
OK, cool! |
36ca146: [gftools-packager] Seymour One: Version 1.100; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33] added
f74a87a: description updated