Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seymour One: Version 1.100; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33] added #6598

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

emmamarichal
Copy link
Collaborator

36ca146: [gftools-packager] Seymour One: Version 1.100; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33] added

f74a87a: description updated

…5d5b);gftools[0.9.33] added

* Seymour One Version 1.100; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33] taken from the upstream repo https://github.com/googlefonts/seymourFont at commit googlefonts/seymourFont@67aa8dc.
@emmamarichal
Copy link
Collaborator Author

Precision:
The current name table on the API is a bit weird, and we can't reproduce it. I also had to modify the ID6 with ttx, to keep the same as the previous one.
Here are the name tables:

Current one 1.000
Capture d’écran 2023-08-04 à 10 40 42

Updated 1.100
Capture d’écran 2023-08-04 à 10 41 09

@emmamarichal emmamarichal added III Expand glyphset more features and more language coverage I Font Upgrade labels Aug 4, 2023
@emmamarichal emmamarichal linked an issue Aug 4, 2023 that may be closed by this pull request
@RosaWagner RosaWagner self-requested a review August 30, 2023 08:06
@RosaWagner
Copy link
Contributor

Indeed "book" as nameID 2 is a bit weird and definitely has to be corrected. The question is; will it break anything? It might. At the same time, the statistics on this font are very low… let's talk about it at the meeting later.

@RosaWagner RosaWagner added the -- Needs manager's opinion from upper level label Aug 30, 2023
@emmamarichal
Copy link
Collaborator Author

I think it should be ok, Dave told me that "only psname is sensitive and the id2 name isn't used anywhere in Google systems afaik"

@RosaWagner RosaWagner removed the -- Needs manager's opinion from upper level label Aug 30, 2023
@RosaWagner
Copy link
Contributor

That's what I needed to hear, let's go then!

@RosaWagner RosaWagner merged commit ca73d07 into main Aug 30, 2023
9 checks passed
@RosaWagner RosaWagner deleted the gftools_packager_ofl_seymourone branch August 30, 2023 12:55
@rsheeter rsheeter mentioned this pull request Aug 31, 2023
@felipesanches
Copy link
Collaborator

Why wasn't a fontbakery CI job run on this PR?

I see that it did trigger the job on other PRs (such as at #6652) so why didn't it run here? Is it perhaps a bug in the google/fonts gh-actions workflow setup?

@felipesanches
Copy link
Collaborator

felipesanches commented Sep 1, 2023

Simon told me that it did actually run:
https://github.com/google/fonts/actions/runs/6022239236/job/16336586219#step:6:1775

but a comment was not automatically posted to this PR, so Simon is now trying to fix the bug, which seems to be on diffenator2 (or on gftools-qa). Thanks, @simoncozens!

@simoncozens
Copy link
Collaborator

I'm going to be doing some tests on the CI using this PR, please excuse the comment spam.

@simoncozens
Copy link
Collaborator

Fontbakery report

Fontbakery version: 0.8.9

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[24] SeymourOne-Regular.ttf
💔 ERROR: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 💔 ERROR Failed with IndexError: list index out of range
💔 ERROR: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • 💔 ERROR The condition FontBakeryCondition:outlines_dict had an error: AttributeError: '_TTGlyphGlyf' object has no attribute '_glyph'
💔 ERROR: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
  • 💔 ERROR The condition FontBakeryCondition:outlines_dict had an error: AttributeError: '_TTGlyphGlyf' object has no attribute '_glyph'
💔 ERROR: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • 💔 ERROR The condition FontBakeryCondition:outlines_dict had an error: AttributeError: '_TTGlyphGlyf' object has no attribute '_glyph'
💔 ERROR: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
  • 💔 ERROR The condition FontBakeryCondition:outlines_dict had an error: AttributeError: '_TTGlyphGlyf' object has no attribute '_glyph'
💔 ERROR: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
  • 💔 ERROR The condition FontBakeryCondition:outlines_dict had an error: AttributeError: '_TTGlyphGlyf' object has no attribute '_glyph'
🔥 FAIL: Check METADATA.pb parse correctly. (com.google.fonts/check/metadata/parses)
  • 🔥 FAIL Family metadata at . failed to parse.
    TRACEBACK:
    22:1 : Message type "google.fonts_public.SourceProto" has no field named "stroke". [code: parsing-error]
🔥 FAIL: Version number has increased since previous release on Google Fonts? (com.google.fonts/check/version_bump)
  • 🔥 FAIL Version number 1.100006103515625 is equal to version on Google Fonts GitHub repo.
🔥 FAIL: Check name table: POSTSCRIPT_NAME entries. (com.google.fonts/check/name/postscriptname)
  • 🔥 FAIL [POSTSCRIPT_NAME(6):WINDOWS(3)]
    Expected: "SeymourOne-Regular"
    But got: "SeymourOne" [code: bad-entry]
WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'newt' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)
  • WARN Following glyphs differ greatly from Google Fonts version:
    • two
    • uni0421
    • V
    • uni01CC
    • ibreve
    • uni0136
    • uni0209
    • J
    • imacron
    • Wgrave and 277 more.

Use -F or --full-lists to disable shortening of long lists.

WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • And i + l [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
  • WARN The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: eogonek	Contours detected: 3	Expected: 2

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: uni1E9E	Contours detected: 2	Expected: 1

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: eogonek	Contours detected: 3	Expected: 2

- Glyph name: fi	Contours detected: 2	Expected: 3

- Glyph name: fl	Contours detected: 1	Expected: 2

- Glyph name: uni1E9E	Contours detected: 2	Expected: 1 

- And Glyph name: uogonek	Contours detected: 2	Expected: 1

[code: contour-count]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
SeymourOne-Regular.ttf
Dehinted Size 59.9kb
Hinted Size 91.4kb
Increase 31.5kb
Change 52.6 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.100; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.33]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • And gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO . [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
6 3 8 98 8 112 0
3% 1% 3% 42% 3% 48% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@felipesanches
Copy link
Collaborator

This report was generated by fontbakery version 0.8.9 but we should be running pre-releases, so it should've been v0.9.0a2

@simoncozens
Copy link
Collaborator

This is fine for this purpose; I'm just testing gftools qa refactors specifically, and I happen to have an old fontbakery installed.

@felipesanches
Copy link
Collaborator

OK, cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Font Upgrade III Expand glyphset more features and more language coverage
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Update Seymour One [Vernon Adams]
4 participants