Update Noto Serif HK #6691

simoncozens · 2023-09-11T20:01:45Z

Closes #6534.

github-actions · 2023-09-11T20:17:24Z

FontBakery report

fontbakery version: 0.9.0a3

[1] Family checks

ℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)

ℹ INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1) [code: summary]

[32] NotoSerifHK[wght].ttf

🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)

🔥 FAIL Missing required codepoints:
- 0x0308 (COMBINING DIAERESIS)
- 0x030B (COMBINING DOUBLE ACUTE ACCENT)
- 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)
- 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)
- 0x010C (LATIN CAPITAL LETTER C WITH CARON)
- 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)
- 0x010E (LATIN CAPITAL LETTER D WITH CARON)
- 0x0116 (LATIN CAPITAL LETTER E WITH DOT ABOVE)
- 0x0118 (LATIN CAPITAL LETTER E WITH OGONEK)
- 0x011E (LATIN CAPITAL LETTER G WITH BREVE)
- 93 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)

🔥 FAIL First line in license file is:

which does not match the expected format, similar to:

🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)

🔥 FAIL Font file is 16.1Mb, larger than limit 9.0Mb [code: massive-font]

🔥 FAIL: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)

🔥 FAIL Font is missing the 'gasp' table. Try exporting the font with autohinting enabled.
If you are dealing with an unhinted font, it can be fixed by running the fonts through the command 'gftools fix-nonhinting'
GFTools is available at https://pypi.org/project/gftools/ [code: lacks-gasp]

🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)

🔥 FAIL METADATA.pb font.name field ("Noto Serif HK") does not match correct font name format ("Noto Serif HK ExtraLight"). [code: mismatch]

🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)

🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
"Copyright 2020 The Familyname Project Authors (git url)"
But instead we have got:
"(c) 2017-2023 adobe (http://www.adobe.com/)." [code: bad-notice-format]

🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)

🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
But instead we have got:
"(c) 2017-2023 Adobe (http://www.adobe.com/)." [code: bad-notice-format]

🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)

🔥 FAIL Value of repository_url field is

But font copyright string has: http://www.adobe.com/
[code: mismatch]

🔥 FAIL: Font enables smart dropout control in "prep" table instructions? (com.google.fonts/check/smart_dropout)

🔥 FAIL The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script. [code: lacks-smart-dropout]

🔥 FAIL: Check if the vertical metrics of a CJK family are similar to the same family hosted on Google Fonts. (com.google.fonts/check/cjk_vertical_metrics_regressions)

🔥 FAIL hhea ascent is 1151 when it should be 1000 [code: cjk-metric-regression]
🔥 FAIL hhea descent is -286 when it should be -200 [code: cjk-metric-regression]

🔥 FAIL: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)

🔥 FAIL Font can't render "yue_Hant" sample text:
"鉴于对人权嘅无视同埋侮蔑经已发展成为野蛮暴行，呢些暴行玷污咗人类嘅良心，而一个人人都有言论同埋信仰自由而且冇惊冇穷嘅世界嘅嚟临"
[code: sample-text]
⚠ WARN Aparently there's no sample strings for 'cjy_Hant' in the gflanguages package. [code: no-sample-string]
⚠ WARN Aparently there's no sample strings for 'gan_Hant' in the gflanguages package. [code: no-sample-string]
⚠ WARN Aparently there's no sample strings for 'hsn_Hant' in the gflanguages package. [code: no-sample-string]
⚠ WARN Aparently there's no sample strings for 'wuu_Hant' in the gflanguages package. [code: no-sample-string]

🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)

🔥 FAIL The following glyphs could not be attached to the dotted circle glyph:
- acutecomb
- gravecomb
- uni0307
- uni030C [code: unattached-dotted-circle-marks]

⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)

⚠ WARN The following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.
U+02C7 CARON: try adding one of: yi, canadian-aboriginal, tifinagh
U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
U+0307 COMBINING DOT ABOVE: try adding one of: coptic, tai-le, canadian-aboriginal, syriac, tifinagh, math, malayalam, old-permic
U+030C COMBINING CARON: try adding one of: cherokee, tai-le
U+0391 GREEK CAPITAL LETTER ALPHA: try adding one of: elbasan, math, greek
U+0392 GREEK CAPITAL LETTER BETA: try adding one of: elbasan, math, greek
U+0393 GREEK CAPITAL LETTER GAMMA: try adding one of: elbasan, math, greek
U+0394 GREEK CAPITAL LETTER DELTA: try adding one of: elbasan, math, greek
U+0395 GREEK CAPITAL LETTER EPSILON: try adding one of: elbasan, math, greek
U+0396 GREEK CAPITAL LETTER ZETA: try adding one of: elbasan, math, greek
2493 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: chinese-hongkong, cyrillic, latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]

⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)

⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]

⚠ WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)

⚠ WARN Following glyphs differ greatly from Google Fonts version:
- A
- AE
- Aacute
- Abreve
- Acircumflex
- Adieresis
- Agrave
- Alpha
- Amacron
- Aring and 19840 more.

Use -F or --full-lists to disable shortening of long lists.

⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)

⚠ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]

⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)

⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:
- f + f
- f + i
- i + f
- f + l
- l + f
- i + l [code: lacks-kern-info]

⚠ WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)

⚠ WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
FONT_FAMILY_NAME = 'Noto Serif HK ExtraLight' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)

⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]

⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)

⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]

⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)

⚠ WARN The following glyphs could not be reached by codepoint or substitution rules:
- glyph00470
- glyph00472
- glyph00473
- glyph00477
- glyph00603
- glyph01006
- glyph01112
- glyph01134
- glyph01668
- glyph01670
- 96 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

⚠ WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)

⚠ WARN This font has a 'Soft Hyphen' character. [code: softhyphen]

⚠ WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)

⚠ WARN chws feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it. [code: missing-chws-feature]
⚠ WARN vchw feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it. [code: missing-vchw-feature]

⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)

⚠ WARN The most common width is 1000 among a set of 43 math glyphs.
The following math glyphs have a different width, though:

Width = 571:
greater, plus, less, minus, equal, logicalnot
[code: width-outliers]

⚠ WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)

⚠ WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]

⚠ WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)

⚠ WARN The following mark characters could be in the GDEF mark glyph class:
uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C), uni302D (U+302D), uni3099 (U+3099) and uni309A (U+309A) [code: mark-chars]

ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)

ℹ INFO Hinting filesize impact:

	ofl/notoserifhk/NotoSerifHK[wght].ttf
Dehinted Size	16.1Mb
Hinted Size	16.1Mb
Increase	-24 bytes
Change	-0.0 %
[code: size-impact]

ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)

ℹ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.002-H1;hotconv 1.1.0;makeotfexe 2.6.0'] [code: version-not-detected]

ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)

ℹ INFO EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818 [code: lacks-EPAR]

ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)

ℹ INFO Version string is: "Version 2.002-H1;hotconv 1.1.0;makeotfexe 2.6.0"
The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
"Version 1.3; git-0d08353-release" [code: bad-format]

ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)

ℹ INFO This font contains the following optional tables:
- loca
- BASE
- GPOS
- GSUB
- vhea
- vmtx [code: optional-tables]

ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)

ℹ INFO ofl/notoserifhk [code: family-path]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	12	14	50	7	166	0
0%	5%	6%	20%	3%	67%	0%

Note: The following loglevels were omitted in this report:

SKIP
PASS
DEBUG

simoncozens · 2023-09-12T08:12:16Z

Just realised this (and the others) was not generated correctly due to changes in gftools-fix.

github-actions · 2023-09-12T08:32:28Z

FontBakery report

fontbakery version: 0.9.0a3

[1] Family checks

ℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)

ℹ INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1) [code: summary]

[31] NotoSerifHK[wght].ttf

🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)

🔥 FAIL Missing required codepoints:
- 0x0308 (COMBINING DIAERESIS)
- 0x030B (COMBINING DOUBLE ACUTE ACCENT)
- 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)
- 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)
- 0x010C (LATIN CAPITAL LETTER C WITH CARON)
- 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)
- 0x010E (LATIN CAPITAL LETTER D WITH CARON)
- 0x0116 (LATIN CAPITAL LETTER E WITH DOT ABOVE)
- 0x0118 (LATIN CAPITAL LETTER E WITH OGONEK)
- 0x011E (LATIN CAPITAL LETTER G WITH BREVE)
- 93 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)

🔥 FAIL First line in license file is:

which does not match the expected format, similar to:

🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)

🔥 FAIL Font file is 16.1Mb, larger than limit 9.0Mb [code: massive-font]

🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)

🔥 FAIL METADATA.pb font.name field ("Noto Serif HK") does not match correct font name format ("Noto Serif HK ExtraLight"). [code: mismatch]

🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)

🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
"Copyright 2020 The Familyname Project Authors (git url)"
But instead we have got:
"(c) 2017-2023 adobe (http://www.adobe.com/)." [code: bad-notice-format]

🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)

🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
But instead we have got:
"(c) 2017-2023 Adobe (http://www.adobe.com/)." [code: bad-notice-format]

🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)

🔥 FAIL Value of repository_url field is

But font copyright string has: http://www.adobe.com/
[code: mismatch]

🔥 FAIL: Check if the vertical metrics of a CJK family are similar to the same family hosted on Google Fonts. (com.google.fonts/check/cjk_vertical_metrics_regressions)

🔥 FAIL hhea ascent is 1151 when it should be 1000 [code: cjk-metric-regression]
🔥 FAIL hhea descent is -286 when it should be -200 [code: cjk-metric-regression]

🔥 FAIL: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)

🔥 FAIL Font can't render "yue_Hant" sample text:
"鉴于对人权嘅无视同埋侮蔑经已发展成为野蛮暴行，呢些暴行玷污咗人类嘅良心，而一个人人都有言论同埋信仰自由而且冇惊冇穷嘅世界嘅嚟临"
[code: sample-text]
⚠ WARN Aparently there's no sample strings for 'cjy_Hant' in the gflanguages package. [code: no-sample-string]
⚠ WARN Aparently there's no sample strings for 'gan_Hant' in the gflanguages package. [code: no-sample-string]
⚠ WARN Aparently there's no sample strings for 'hsn_Hant' in the gflanguages package. [code: no-sample-string]
⚠ WARN Aparently there's no sample strings for 'wuu_Hant' in the gflanguages package. [code: no-sample-string]

🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)

🔥 FAIL The following glyphs could not be attached to the dotted circle glyph:
- acutecomb
- gravecomb
- uni0307
- uni030C [code: unattached-dotted-circle-marks]

⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)

⚠ WARN The following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.
U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal
U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
U+0307 COMBINING DOT ABOVE: try adding one of: coptic, syriac, malayalam, canadian-aboriginal, math, tifinagh, tai-le, old-permic
U+030C COMBINING CARON: try adding one of: tai-le, cherokee
U+0391 GREEK CAPITAL LETTER ALPHA: try adding one of: elbasan, math, greek
U+0392 GREEK CAPITAL LETTER BETA: try adding one of: elbasan, math, greek
U+0393 GREEK CAPITAL LETTER GAMMA: try adding one of: elbasan, math, greek
U+0394 GREEK CAPITAL LETTER DELTA: try adding one of: elbasan, math, greek
U+0395 GREEK CAPITAL LETTER EPSILON: try adding one of: elbasan, math, greek
U+0396 GREEK CAPITAL LETTER ZETA: try adding one of: elbasan, math, greek
2493 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: chinese-hongkong, cyrillic, latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]

⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)

⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]

⚠ WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)

⚠ WARN Following glyphs differ greatly from Google Fonts version:
- A
- AE
- Aacute
- Abreve
- Acircumflex
- Adieresis
- Agrave
- Alpha
- Amacron
- Aring and 19840 more.

Use -F or --full-lists to disable shortening of long lists.

⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)

⚠ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]

⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)

⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:
- f + f
- f + i
- i + f
- f + l
- l + f
- i + l [code: lacks-kern-info]

⚠ WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)

⚠ WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
FONT_FAMILY_NAME = 'Noto Serif HK ExtraLight' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)

⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]

⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)

⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]

⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)

⚠ WARN The following glyphs could not be reached by codepoint or substitution rules:
- glyph00470
- glyph00472
- glyph00473
- glyph00477
- glyph00603
- glyph01006
- glyph01112
- glyph01134
- glyph01668
- glyph01670
- 96 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

⚠ WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)

⚠ WARN This font has a 'Soft Hyphen' character. [code: softhyphen]

⚠ WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)

⚠ WARN chws feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it. [code: missing-chws-feature]
⚠ WARN vchw feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it. [code: missing-vchw-feature]

⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)

⚠ WARN The most common width is 1000 among a set of 43 math glyphs.
The following math glyphs have a different width, though:

Width = 571:
equal, less, plus, greater, logicalnot, minus
[code: width-outliers]

⚠ WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)

⚠ WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]

⚠ WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)

⚠ WARN The following mark characters could be in the GDEF mark glyph class:
uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C), uni302D (U+302D), uni3099 (U+3099) and uni309A (U+309A) [code: mark-chars]

ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)

ℹ INFO Hinting filesize impact:

	ofl/notoserifhk/NotoSerifHK[wght].ttf
Dehinted Size	16.1Mb
Hinted Size	16.1Mb
Increase	24 bytes
Change	0.0 %
[code: size-impact]

ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)

ℹ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.002-H1;hotconv 1.1.0;makeotfexe 2.6.0'] [code: version-not-detected]

ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)

ℹ INFO EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818 [code: lacks-EPAR]

ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)

ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)

ℹ INFO Version string is: "Version 2.002-H1;hotconv 1.1.0;makeotfexe 2.6.0"
The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
"Version 1.3; git-0d08353-release" [code: bad-format]

ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)

ℹ INFO This font contains the following optional tables:
- loca
- prep
- BASE
- GPOS
- GSUB
- gasp
- vhea
- vmtx [code: optional-tables]

ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)

ℹ INFO ofl/notoserifhk [code: family-path]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	10	14	50	8	167	0
0%	4%	6%	20%	3%	67%	0%

Note: The following loglevels were omitted in this report:

SKIP
PASS
DEBUG

github-actions · 2023-09-15T10:50:17Z

FontBakery report

fontbakery version: 0.9.0

[1] Family checks

ℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)

ℹ INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1) [code: summary]

[31] NotoSerifHK[wght].ttf

🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)

🔥 FAIL Missing required codepoints:
- 0x0308 (COMBINING DIAERESIS)
- 0x030B (COMBINING DOUBLE ACUTE ACCENT)
- 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)
- 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)
- 0x010C (LATIN CAPITAL LETTER C WITH CARON)
- 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)
- 0x010E (LATIN CAPITAL LETTER D WITH CARON)
- 0x0116 (LATIN CAPITAL LETTER E WITH DOT ABOVE)
- 0x0118 (LATIN CAPITAL LETTER E WITH OGONEK)
- 0x011E (LATIN CAPITAL LETTER G WITH BREVE)
- 93 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)

🔥 FAIL First line in license file is:

which does not match the expected format, similar to:

🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)

🔥 FAIL Font file is 16.1Mb, larger than limit 9.0Mb [code: massive-font]

🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)

🔥 FAIL METADATA.pb font.name field ("Noto Serif HK") does not match correct font name format ("Noto Serif HK ExtraLight"). [code: mismatch]

🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)

🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
"Copyright 2020 The Familyname Project Authors (git url)"
But instead we have got:
"(c) 2017-2023 adobe (http://www.adobe.com/)." [code: bad-notice-format]

🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)

🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
But instead we have got:
"(c) 2017-2023 Adobe (http://www.adobe.com/)." [code: bad-notice-format]

🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)

🔥 FAIL Value of repository_url field is

But font copyright string has: http://www.adobe.com/
[code: mismatch]

🔥 FAIL: Check if the vertical metrics of a CJK family are similar to the same family hosted on Google Fonts. (com.google.fonts/check/cjk_vertical_metrics_regressions)

🔥 FAIL hhea ascent is 1151 when it should be 1000 [code: cjk-metric-regression]
🔥 FAIL hhea descent is -286 when it should be -200 [code: cjk-metric-regression]

🔥 FAIL: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)

🔥 FAIL Font can't render "yue_Hant" sample text:
"鉴于对人权嘅无视同埋侮蔑经已发展成为野蛮暴行，呢些暴行玷污咗人类嘅良心，而一个人人都有言论同埋信仰自由而且冇惊冇穷嘅世界嘅嚟临"
[code: sample-text]
⚠ WARN Aparently there's no sample strings for 'cjy_Hant' in the gflanguages package. [code: no-sample-string]
⚠ WARN Aparently there's no sample strings for 'gan_Hant' in the gflanguages package. [code: no-sample-string]
⚠ WARN Aparently there's no sample strings for 'hsn_Hant' in the gflanguages package. [code: no-sample-string]
⚠ WARN Aparently there's no sample strings for 'wuu_Hant' in the gflanguages package. [code: no-sample-string]

🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)

🔥 FAIL The following glyphs could not be attached to the dotted circle glyph:
- acutecomb
- gravecomb
- uni0307
- uni030C [code: unattached-dotted-circle-marks]

⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)

⚠ WARN The following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.
U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal
U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
U+0307 COMBINING DOT ABOVE: try adding one of: coptic, tai-le, tifinagh, canadian-aboriginal, old-permic, malayalam, math, syriac
U+030C COMBINING CARON: try adding one of: tai-le, cherokee
U+0391 GREEK CAPITAL LETTER ALPHA: try adding one of: math, elbasan, greek
U+0392 GREEK CAPITAL LETTER BETA: try adding one of: math, elbasan, greek
U+0393 GREEK CAPITAL LETTER GAMMA: try adding one of: math, elbasan, greek
U+0394 GREEK CAPITAL LETTER DELTA: try adding one of: math, elbasan, greek
U+0395 GREEK CAPITAL LETTER EPSILON: try adding one of: math, elbasan, greek
U+0396 GREEK CAPITAL LETTER ZETA: try adding one of: math, elbasan, greek
2493 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: chinese-hongkong, cyrillic, latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]

⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)

⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]

⚠ WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)

⚠ WARN Following glyphs differ greatly from Google Fonts version:
- A
- AE
- Aacute
- Abreve
- Acircumflex
- Adieresis
- Agrave
- Alpha
- Amacron
- Aring and 19840 more.

Use -F or --full-lists to disable shortening of long lists.

⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)

⚠ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]

⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)

⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:
- f + f
- f + i
- i + f
- f + l
- l + f
- i + l [code: lacks-kern-info]

⚠ WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)

⚠ WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
FONT_FAMILY_NAME = 'Noto Serif HK ExtraLight' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)

⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]

⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)

⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]

⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)

⚠ WARN The following glyphs could not be reached by codepoint or substitution rules:
- glyph00470
- glyph00472
- glyph00473
- glyph00477
- glyph00603
- glyph01006
- glyph01112
- glyph01134
- glyph01668
- glyph01670
- 96 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

⚠ WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)

⚠ WARN This font has a 'Soft Hyphen' character. [code: softhyphen]

⚠ WARN: Does the font contain chws and vchw features? (com.google.fonts/check/cjk_chws_feature)

⚠ WARN chws feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it. [code: missing-chws-feature]
⚠ WARN vchw feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it. [code: missing-vchw-feature]

⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)

⚠ WARN The most common width is 1000 among a set of 43 math glyphs.
The following math glyphs have a different width, though:

Width = 571:
logicalnot, greater, less, plus, equal, minus
[code: width-outliers]

⚠ WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)

⚠ WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]

⚠ WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)

⚠ WARN The following mark characters could be in the GDEF mark glyph class:
uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C), uni302D (U+302D), uni3099 (U+3099) and uni309A (U+309A) [code: mark-chars]

ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)

ℹ INFO Hinting filesize impact:

	ofl/notoserifhk/NotoSerifHK[wght].ttf
Dehinted Size	16.1Mb
Hinted Size	16.1Mb
Increase	24 bytes
Change	0.0 %
[code: size-impact]

ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)

ℹ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.002-H1;hotconv 1.1.0;makeotfexe 2.6.0'] [code: version-not-detected]

ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)

ℹ INFO EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818 [code: lacks-EPAR]

ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)

ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)

ℹ INFO Version string is: "Version 2.002-H1;hotconv 1.1.0;makeotfexe 2.6.0"
The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
"Version 1.3; git-0d08353-release" [code: bad-format]

ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)

ℹ INFO This font contains the following optional tables:
- loca
- prep
- BASE
- GPOS
- GSUB
- gasp
- vhea
- vmtx [code: optional-tables]

ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)

ℹ INFO ofl/notoserifhk [code: family-path]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	10	14	50	8	168	0
0%	4%	6%	20%	3%	67%	0%

Note: The following loglevels were omitted in this report:

SKIP
PASS
DEBUG

chrissimpkins · 2023-09-18T22:30:07Z

See #6695 (comment) re subsetter update requirement.

Add Noto Serif HK 2.002 (H1)

2a89f07

simoncozens added II CJK Chinese, Japanese, Korean scripts I Font Upgrade labels Sep 11, 2023

simoncozens marked this pull request as draft September 12, 2023 08:11

Re-run hotfix

7bcb7de

simoncozens marked this pull request as ready for review September 12, 2023 08:16

RosaWagner added - In Progress and removed - In Progress labels Sep 13, 2023

RosaWagner approved these changes Sep 15, 2023

View reviewed changes

RosaWagner merged commit 69df4cd into main Sep 15, 2023
9 checks passed

RosaWagner deleted the notoserifhk-2.002-H1 branch September 15, 2023 14:53

RosaWagner added the -- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) label Sep 21, 2023

felipesanches mentioned this pull request Sep 23, 2023

[com.google.fonts/check/metadata/consistent_repo_urls] Bad output formatting when metadata_pb.repository_url is empty fonttools/fontbakery#4285

Closed

emmamarichal mentioned this pull request Feb 2, 2024

Noto PRs which need attention #6671

Closed

29 tasks

emmamarichal removed the -- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) label Mar 27, 2024

simoncozens mentioned this pull request Mar 28, 2024

Update Noto Serif CJK fonts to variable (summary) #6024

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Noto Serif HK #6691

Update Noto Serif HK #6691

simoncozens commented Sep 11, 2023 •

edited by RosaWagner

Loading

github-actions bot commented Sep 11, 2023

simoncozens commented Sep 12, 2023

github-actions bot commented Sep 12, 2023

github-actions bot commented Sep 15, 2023

chrissimpkins commented Sep 18, 2023

Update Noto Serif HK #6691

Update Noto Serif HK #6691

Conversation

simoncozens commented Sep 11, 2023 • edited by RosaWagner Loading

github-actions bot commented Sep 11, 2023

FontBakery report

Summary

simoncozens commented Sep 12, 2023

github-actions bot commented Sep 12, 2023

FontBakery report

Summary

github-actions bot commented Sep 15, 2023

FontBakery report

Summary

chrissimpkins commented Sep 18, 2023

simoncozens commented Sep 11, 2023 •

edited by RosaWagner

Loading