Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_prod list update July 3th #7917

Merged
merged 2 commits into from
Jul 3, 2024
Merged

to_prod list update July 3th #7917

merged 2 commits into from
Jul 3, 2024

Conversation

vv-monsalve
Copy link
Collaborator

This quick update to the list includes the remaining Playwrite projects plus a couple of new additions.

@vv-monsalve vv-monsalve merged commit 2000498 into main Jul 3, 2024
8 of 9 checks passed
@vv-monsalve vv-monsalve deleted the prod-list-Jul3th branch July 3, 2024 23:01
Copy link
Collaborator

@chrissimpkins chrissimpkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vv-monsalve I haven't had a chance to review this PR yet. Took a quick look through changes and I think that we need to block the COLRv1 Kalnia Glaze in Workspace before the prod push. Mind removing that one from the list this week?

cc @garretrieger

to_production.txt Show resolved Hide resolved
@chrissimpkins
Copy link
Collaborator

chrissimpkins commented Jul 4, 2024

@m4rc1e we've had CI fails on every list PR over the last few weeks. If this is a test that we are regularly ignoring can we remove it altogether?

@vv-monsalve
Copy link
Collaborator Author

vv-monsalve commented Jul 4, 2024

@chrissimpkins I merged it since the last time we did a quick update to the lists, you said there was no need for you to review it if there were no projects to review in WS before merging. I've noticed now that the Edu VIC project was not previously on the list. Apologies. Going forward, I'll always wait for your revision before merging.

Kalnia Glaze
I added Kalnia Glaze after checking about the SVG table with Garret, where he said:

Ah ok, in that case I think we're good to remove Kalnia Glaze from the sandbox denylist.

CI Fail
Before merging this one, I checked that the latest PRs had been merged with that CI Fail. However, I opened a PR to fix the broken link in one of the Knowledge pages. The last time I was on call, Dave fixed the source of the problem reported by the Knowledge CI by updating the broken link reported and said that we could continue doing so when seeing these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants