Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parkinsans: Version 1.000 added #8470

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

emmamarichal
Copy link
Collaborator

@emmamarichal emmamarichal commented Nov 7, 2024

No description provided.

@emmamarichal emmamarichal linked an issue Nov 7, 2024 that may be closed by this pull request
9 tasks

This comment was marked as outdated.

This comment was marked as outdated.

@vv-monsalve
Copy link
Collaborator

@emmamarichal

  • Ŀ ŀ are showing a weird interpolation. Alternatively, if the font has periodcentered.loclCAT I think you can mark this glyph as non-export. We have deprecate it from our glyphsets, considered a legacy encoding.
Screen.Recording.2024-11-07.at.09.25.55.mov

  • hbar legibility is affected, especially at dark weights in small sizes.
Screenshot 2024-11-07 at 09 48 09 Screenshot 2024-11-07 at 09 32 32
  • Acute in Ǽ looks shifted off
Screenshot 2024-11-07 at 09 27 11

@vv-monsalve vv-monsalve added the -- Needs Upstream Resolution Upstream fix required before moving forward label Nov 7, 2024
@emmamarichal
Copy link
Collaborator Author

@vv-monsalve ok great, thank you, I'll try to implement the changes this afternoon!

@emmamarichal
Copy link
Collaborator Author

Updated

@emmamarichal emmamarichal force-pushed the gftools_packager_ofl_parkinsans branch from 2af48f5 to 0de6c6b Compare November 7, 2024 15:48
@emmamarichal
Copy link
Collaborator Author

@vv-monsalve updated!

Copy link

github-actions bot commented Nov 7, 2024

FontBakery report

fontbakery version: 0.13.0a4

Check results

[17] Parkinsans[wght].ttf
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + i

- f + l

[code: lacks-kern-info]

⚠️ WARN Ensure variable fonts include an avar table.
  • ⚠️ WARN

    This variable font does not have an avar table. Most variable fonts should include an avar table to correctly define axes progression rates.


    [code: missing-avar]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Article page is too short!


    [code: length-requirements-not-met]
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
  • ⚠️ WARN

    It seems that Red Stone is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, cherokee, math, tifinagh
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, hebrew, tai-le, todhri, malayalam, duployan, syriac, coptic, old-permic, math, canadian-aboriginal
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
  • U+0326 COMBINING COMMA BELOW: try adding math 24 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets.
  • ⚠️ WARN

    GF_TransLatin_Arabic glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: Ŀ, ŀ ca_Latn (Catalan)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ŋ, ŋ, Ŧ, ŧ, Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
Some auxiliary glyphs were missing: Ŋ, ŋ, Ŧ, ŧ nb_Latn (Norwegian Bokmål)
Some auxiliary glyphs were missing: IJ, ij nl_Latn (Dutch)
[code: warning-language-shaping]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̧̀ į̧́ į̧̂ į̧̃

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Dii (Latn, 71,000 speakers), Teke-Ebo (Latn, 260,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Gulay (Latn, 250,478 speakers), Ma’di (Latn, 584,000 speakers), Kaska (Latn, 125 speakers), Bete-Bendi (Latn, 100,000 speakers), Mundani (Latn, 34,000 speakers), Fur (Latn, 1,230,163 speakers), Bafut (Latn, 158,146 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Southern Tutchone (Latn, 65 speakers), Dan (Latn, 1,099,244 speakers), Zapotec (Latn, 490,000 speakers), Ikwere (Latn, 717,000 speakers), Northern Tutchone (Latn, 85 speakers), Yala (Latn, 200,000 speakers), Kom (Latn, 360,685 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Longto (Latn, 5,000 speakers), Navajo (Latn, 166,319 speakers), Koonzime (Latn, 40,000 speakers), Ebira (Latn, 2,200,000 speakers), Basaa (Latn, 332,940 speakers), Abua (Latn, 25,000 speakers), Han (Latn, 6 speakers), Mango (Latn, 77,000 speakers), Lugbara (Latn, 2,200,000 speakers), Nzakara (Latn, 50,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Sar (Latn, 500,000 speakers), South Central Banda (Latn, 244,000 speakers), Mfumte (Latn, 79,000 speakers), Aghem (Latn, 38,843 speakers), Keliko (Latn, 63,000 speakers), Makaa (Latn, 221,000 speakers), Heiltsuk (Latn, 300 speakers), Vute (Latn, 21,000 speakers), Ekpeye (Latn, 226,000 speakers), Ejagham (Latn, 120,000 speakers), Southern Kisi (Latn, 360,000 speakers), Igbo (Latn, 27,823,640 speakers), Avokaya (Latn, 100,000 speakers), Western Krahn (Latn, 97,800 speakers), Nateni (Latn, 100,000 speakers), Cicipu (Latn, 44,000 speakers).

[code: soft-dotted]
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* uni1E9E (U+1E9E): X=473.0,Y=688.0 (should be at cap-height 690?)

* lcaron (U+013E): X=207.0,Y=691.0 (should be at cap-height 690?)

* obreve (U+014F): X=251.5,Y=688.0 (should be at cap-height 690?)

* obreve (U+014F): X=390.5,Y=688.0 (should be at cap-height 690?)

* germandbls (U+00DF): X=473.0,Y=688.0 (should be at cap-height 690?)

* t (U+0074): X=293.0,Y=0.5 (should be at baseline 0?)

* tcaron (U+0165): X=293.0,Y=0.5 (should be at baseline 0?)

* uni0163 (U+0163): X=293.0,Y=0.5 (should be at baseline 0?)

* uni021B (U+021B): X=293.0,Y=0.5 (should be at baseline 0?)

* comma (U+002C): X=78.5,Y=-2.0 (should be at baseline 0?)

* 7 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Checking OS/2 achVendID.
  • ⚠️ WARN

    OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/parkinsans


    [code: family-path]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/parkinsans/Parkinsans[wght].ttf
Dehinted Size 90.9kb
Hinted Size 90.9kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ℹ️ INFO

    en, cy


    [code: dlng-tag]

  • ℹ️ INFO

    Latn, Latn-ext, canadian-aboriginal, yi, math, tifinagh, cherokee, coptic, old-permic, todhri, hebrew, duployan, tai-le, syriac, malayalam, greek, vietnamese, adlam, symbols


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 0 9 51 9 183 0
0% 0% 0% 4% 20% 4% 73% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal emmamarichal removed the -- Needs Upstream Resolution Upstream fix required before moving forward label Nov 7, 2024
@vv-monsalve
Copy link
Collaborator

  • ⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?

The #8471 issue will track the designer's addition. I'll merge this here and wait for it to happen in a follow-up PR.

@vv-monsalve vv-monsalve merged commit 5a06479 into main Nov 7, 2024
8 checks passed
@vv-monsalve vv-monsalve deleted the gftools_packager_ofl_parkinsans branch November 7, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Sandbox
Development

Successfully merging this pull request may close these issues.

Add Parkinsans
2 participants