-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Red Hat Mono: Version 1.030 added #8502
base: main
Are you sure you want to change the base?
Conversation
Taken from the upstream repo https://github.com/bghryct/RedHatMono at commit bghryct/RedHatMono@a0f2a70.
For the Mono, the name table changed a bit. We were agree with Mirko and you that, for a Mono, it's not a big risk to update it. Mirko will still ask the confirmation to the designer, I'll hold this PR until we have it :) @vv-monsalve The PR update the instance issue we had. So it's intentional if you see the weight difference in SemiBold and Medium |
FontBakery reportfontbakery version: 0.13.0a5 Check results[21] RedHatMono[wght].ttf💥 ERROR Familyname must be unique according to namecheck.fontdata.com
[code: namecheck-service] 🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/RedHatOfficial/RedHatFont', font copyright string has 'https://github.com/RedHatOfficial/RedHatFont', OFL text has 'https://github.com/RedHatOfficial/RedHatFont' and HTML description has 'github.com/RedHatOfficial/RedHatFont' [code: mismatch]
|
WARN messages | Languages |
---|---|
Some auxiliary glyphs were missing: Ŀ, ŀ | ca_Latn (Catalan) |
Some auxiliary glyphs were missing: ſ | de_Latn (German) and fr_Latn (French) |
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
⚠️ WARN Ensure dotted circle glyph is present and can attach marks.
⚠️ WARNNo dotted circle glyph present
[code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
⚠️ WARNThe dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌
The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́
Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).
Your font does not cover the following languages that require the soft-dotted feature: Southern Tutchone (Latn, 65 speakers), Zapotec (Latn, 490,000 speakers), Fur (Latn, 1,230,163 speakers), Ma’di (Latn, 584,000 speakers), Nzakara (Latn, 50,000 speakers), Ejagham (Latn, 120,000 speakers), Avokaya (Latn, 100,000 speakers), Nateni (Latn, 100,000 speakers), Lugbara (Latn, 2,200,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Ikwere (Latn, 717,000 speakers), Dii (Latn, 71,000 speakers), Cicipu (Latn, 44,000 speakers), Kaska (Latn, 125 speakers), Southern Kisi (Latn, 360,000 speakers), Mfumte (Latn, 79,000 speakers), Heiltsuk (Latn, 300 speakers), Bafut (Latn, 158,146 speakers), Makaa (Latn, 221,000 speakers), Sar (Latn, 500,000 speakers), Gulay (Latn, 250,478 speakers), Ngbaka (Latn, 1,020,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Igbo (Latn, 27,823,640 speakers), Teke-Ebo (Latn, 260,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Mango (Latn, 77,000 speakers), Mundani (Latn, 34,000 speakers), Abua (Latn, 25,000 speakers), Han (Latn, 6 speakers), Bete-Bendi (Latn, 100,000 speakers), Vute (Latn, 21,000 speakers), Ebira (Latn, 2,200,000 speakers), South Central Banda (Latn, 244,000 speakers), Yala (Latn, 200,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Basaa (Latn, 332,940 speakers), Koonzime (Latn, 40,000 speakers), Western Krahn (Latn, 97,800 speakers), Dan (Latn, 1,099,244 speakers), Aghem (Latn, 38,843 speakers), Keliko (Latn, 63,000 speakers), Longto (Latn, 5,000 speakers), Kom (Latn, 360,685 speakers), Navajo (Latn, 166,319 speakers), Northern Tutchone (Latn, 85 speakers), Ekpeye (Latn, 226,000 speakers).
[code: soft-dotted]⚠️ WARN Are there any misaligned on-curve points?
⚠️ WARNThe following glyphs have on-curve points which have potentially incorrect y coordinates:
* V (U+0056): X=505.0,Y=699.0 (should be at cap-height 700?)
* V (U+0056): X=584.0,Y=699.0 (should be at cap-height 700?)
* atilde (U+00E3): X=270.5,Y=699.0 (should be at cap-height 700?)
* itilde (U+0129): X=276.5,Y=699.0 (should be at cap-height 700?)
* ntilde (U+00F1): X=283.5,Y=699.0 (should be at cap-height 700?)
* oslash (U+00F8): X=228.0,Y=1.5 (should be at baseline 0?)
* otilde (U+00F5): X=283.5,Y=699.0 (should be at cap-height 700?)
* uni0163 (U+0163): X=311.0,Y=-2.0 (should be at baseline 0?)
* utilde (U+0169): X=283.5,Y=699.0 (should be at cap-height 700?)
* atilde.school: X=279.5,Y=699.0 (should be at cap-height 700?)
* 12 more.
Use -F or --full-lists to disable shortening of long lists.
[code: found-misalignments]⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
ofl/redhatmono/RedHatMono[wght].ttf | |
---|---|
Dehinted Size | 66.7kb |
Hinted Size | 66.8kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/RedHatOfficial/RedHatFont
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][22] RedHatMono-Italic[wght].ttf
💥 ERROR Familyname must be unique according to namecheck.fontdata.com
- 💥 ERROR
Failed to access: http://namecheck.fontdata.com.
This check relies on the external service http://namecheck.fontdata.com via the internet. While the service cannot be reached or does not respond this check is broken.
You can exclude this check with the command line option:
-x fontdata_namecheck
Or you can wait until the service is available again.
If the problem persists please report this issue at: https://github.com/fonttools/fontbakery/issues
Original error message:
<class 'requests.exceptions.ConnectionError'>
[code: namecheck-service]
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
- 🔥 FAIL
Repository URL is https://github.com/bghryct/RedHatMono
But: font copyright string has 'https://github.com/RedHatOfficial/RedHatFont', font copyright string has 'https://github.com/RedHatOfficial/RedHatFont', OFL text has 'https://github.com/RedHatOfficial/RedHatFont' and HTML description has 'github.com/RedHatOfficial/RedHatFont'
[code: mismatch]⚠️ WARN Checking correctness of monospaced metadata.
⚠️ WARNThe OpenType spec recommends at https://learn.microsoft.com/en-us/typography/opentype/spec/recom#hhea-table that hhea.numberOfHMetrics be set to 3 but this font has 439 instead.
Please read hhea.numberOfHMetrics not correct for monospace fonttools/fonttools#3014 to decide whether this makes sense for your font.
[code: bad-numberOfHMetrics]
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
-
⚠️ WARNLcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline] -
⚠️ WARNdcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline] -
⚠️ WARNlcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline] -
⚠️ WARNtcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline]
⚠️ WARN Check font contains no unreachable glyphs
⚠️ WARNThe following glyphs could not be reached by codepoint or substitution rules:
- NULL
- caronSlovak
- cordinal
- periodcentered.loclCAT
- reversequotedblleft
- reversequoteleft
- uni004A0301
- uni006A0301
- uni030C.alt
[code: unreachable-glyphs]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
⚠️ WARNFamily metadata at ofl/redhatmono does not have an article.
[code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
⚠️ WARNThe following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.
- U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
- U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
- U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
- U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, math, coptic, cherokee
- U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
- U+0307 COMBINING DOT ABOVE: try adding one of: malayalam, todhri, tifinagh, math, coptic, syriac, hebrew, canadian-aboriginal, old-permic, duployan, tai-le
- U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
- U+030C COMBINING CARON: try adding one of: tai-le, cherokee
- U+0312 COMBINING TURNED COMMA ABOVE: try adding math 26 more.
Use -F or --full-lists to disable shortening of long lists.
Or you can add the above codepoints to one of the subsets supported by the font: latin
, latin-ext
, menu
⚠️ WARN Shapes languages in all GF glyphsets.
⚠️ WARNGF_Phonetics_SinoExt glyphset:
WARN messages | Languages |
---|---|
Some auxiliary glyphs were missing: Ŀ, ŀ | ca_Latn (Catalan) |
Some auxiliary glyphs were missing: ſ | de_Latn (German) and fr_Latn (French) |
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
⚠️ WARNThe DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
Please consider mentioning note-worthy improvements made to the family recently.
[code: description-not-updated]
⚠️ WARN Ensure dotted circle glyph is present and can attach marks.
⚠️ WARNNo dotted circle glyph present
[code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
⚠️ WARNThe dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌
The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́
Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).
Your font does not cover the following languages that require the soft-dotted feature: Southern Tutchone (Latn, 65 speakers), Zapotec (Latn, 490,000 speakers), Fur (Latn, 1,230,163 speakers), Ma’di (Latn, 584,000 speakers), Nzakara (Latn, 50,000 speakers), Ejagham (Latn, 120,000 speakers), Avokaya (Latn, 100,000 speakers), Nateni (Latn, 100,000 speakers), Lugbara (Latn, 2,200,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Ikwere (Latn, 717,000 speakers), Dii (Latn, 71,000 speakers), Cicipu (Latn, 44,000 speakers), Kaska (Latn, 125 speakers), Southern Kisi (Latn, 360,000 speakers), Mfumte (Latn, 79,000 speakers), Heiltsuk (Latn, 300 speakers), Bafut (Latn, 158,146 speakers), Makaa (Latn, 221,000 speakers), Sar (Latn, 500,000 speakers), Gulay (Latn, 250,478 speakers), Ngbaka (Latn, 1,020,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Igbo (Latn, 27,823,640 speakers), Teke-Ebo (Latn, 260,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Mango (Latn, 77,000 speakers), Mundani (Latn, 34,000 speakers), Abua (Latn, 25,000 speakers), Han (Latn, 6 speakers), Bete-Bendi (Latn, 100,000 speakers), Vute (Latn, 21,000 speakers), Ebira (Latn, 2,200,000 speakers), South Central Banda (Latn, 244,000 speakers), Yala (Latn, 200,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Basaa (Latn, 332,940 speakers), Koonzime (Latn, 40,000 speakers), Western Krahn (Latn, 97,800 speakers), Dan (Latn, 1,099,244 speakers), Aghem (Latn, 38,843 speakers), Keliko (Latn, 63,000 speakers), Longto (Latn, 5,000 speakers), Kom (Latn, 360,685 speakers), Navajo (Latn, 166,319 speakers), Northern Tutchone (Latn, 85 speakers), Ekpeye (Latn, 226,000 speakers).
[code: soft-dotted]⚠️ WARN Are there any misaligned on-curve points?
⚠️ WARNThe following glyphs have on-curve points which have potentially incorrect y coordinates:
* Uogonek (U+0172): X=349.0,Y=-2.0 (should be at baseline 0?)
* abreve (U+0103): X=532.0,Y=702.0 (should be at cap-height 700?)
* atilde (U+00E3): X=543.0,Y=698.0 (should be at cap-height 700?)
* ae (U+00E6): X=466.0,Y=-1.5 (should be at baseline 0?)
* eth (U+00F0): X=411.5,Y=700.5 (should be at cap-height 700?)
* ebreve (U+0115): X=527.0,Y=702.0 (should be at cap-height 700?)
* gbreve (U+011F): X=535.0,Y=702.0 (should be at cap-height 700?)
* ibreve (U+012D): X=546.0,Y=702.0 (should be at cap-height 700?)
* itilde (U+0129): X=557.0,Y=698.0 (should be at cap-height 700?)
* ntilde (U+00F1): X=574.0,Y=698.0 (should be at cap-height 700?)
* 32 more.
Use -F or --full-lists to disable shortening of long lists.
[code: found-misalignments]⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
ofl/redhatmono/RedHatMono-Italic[wght].ttf | |
---|---|
Dehinted Size | 70.1kb |
Hinted Size | 70.1kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/RedHatOfficial/RedHatFont
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
2 | 0 | 2 | 21 | 81 | 19 | 361 | 0 |
0% | 0% | 0% | 4% | 17% | 4% | 74% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Maybe also an opportunity to add /Monospace/Monospace for Red Hat Mono in families.csv? |
@thlinard, Indeed. We are currently updating the family.csv, it's a long process, and we are currently adding the missing families. But we will try to focus on that asap! Actually, I see @m4rc1e started to add some missing Mono family. Marc, do you want to add the missing list? I can do it also: #8466 |
Sounds good. For the other issues, same comment as in Red Hat Display |
Taken from the upstream repo https://github.com/bghryct/RedHatMono at commit https://github.com/bghryct/RedHatMono/commit/a0f2a7032143500e44dfd569d09ba30414d51a1c.
PR Checklist:
minisite_url
definition in the METADATA.pb file for commissioned projectstags
are added for NEW FONTSprimary_script
definition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsets
definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong
,chinese-simplified
,chinese-traditional
,korean
,japanese
.