Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If fq_schema_naming is true, use service fullname as the operation tagname #369

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

If fq_schema_naming is true, use service fullname as the operation tagname #369

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4e71484
feat(protoc-gen-openapi): If fq_schema_naming is true, use service fu…
comynli Nov 15, 2022
e664f2d
feat(protoc-gen-openapi): If fq_schema_naming is true, use service fu…
comynli Nov 15, 2022
aa4bba6
Merge branch 'main' into main
morphar Dec 10, 2022
b79768f
Merge branch 'main' into main
timburks Mar 3, 2023
a2f5a43
Merge branch 'main' into main
timburks Mar 24, 2023
f77b5ad
Update generator.go
timburks Mar 24, 2023
0ad4f86
Merge branch 'main' into main
timburks May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmd/protoc-gen-openapi/generator/generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,6 +687,11 @@ func (g *OpenAPIv3Generator) addPathsToDocumentV3(d *v3.Document, services []*pr
for _, service := range services {
annotationsCount := 0

tagName := service.GoName
if g.conf.FQSchemaNaming != nil && *g.conf.FQSchemaNaming {
tagName = string(service.Desc.FullName())
}

for _, method := range service.Methods {
comment := g.filterCommentString(method.Comments.Leading)
inputMessage := method.Input
Expand Down Expand Up @@ -751,7 +756,7 @@ func (g *OpenAPIv3Generator) addPathsToDocumentV3(d *v3.Document, services []*pr

if annotationsCount > 0 {
comment := g.filterCommentString(service.Comments.Leading)
d.Tags = append(d.Tags, &v3.Tag{Name: service.GoName, Description: comment})
d.Tags = append(d.Tags, &v3.Tag{Name: tagName, Description: comment})
}
}
}
Expand Down