-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CaptureLocation & DropPin task] Fix crashes on config change #2765
Conversation
…o gino-m/2725/fix-task-constructors
…s' into gino-m/2725/fix-task-constructors
…-support # Conflicts: # ground/src/main/java/com/google/android/ground/ui/datacollection/tasks/polygon/DrawAreaTaskFragment.kt
…pport' into anandwana001/2764/task-config-support
@gino-m tried test Idea was to mock the instance of but, not able to mock the instance of |
What about creating a real instance of the parent fragment instead of the child as we do now, and configuring that instead? Could that work? |
…upport # Conflicts: # ground/src/main/java/com/google/android/ground/ui/datacollection/DataCollectionFragment.kt # ground/src/main/java/com/google/android/ground/ui/datacollection/DataCollectionViewPagerAdapter.kt # ground/src/main/java/com/google/android/ground/ui/datacollection/tasks/polygon/DrawAreaTaskFragment.kt # ground/src/main/java/com/google/android/ground/ui/datacollection/tasks/polygon/DrawAreaTaskMapFragment.kt # ground/src/test/java/com/google/android/ground/HiltExt.kt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2765 +/- ##
============================================
- Coverage 60.90% 60.89% -0.02%
Complexity 1162 1162
============================================
Files 265 265
Lines 6169 6175 +6
Branches 860 859 -1
============================================
+ Hits 3757 3760 +3
- Misses 1922 1924 +2
- Partials 490 491 +1
|
...com/google/android/ground/ui/datacollection/tasks/location/CaptureLocationTaskMapFragment.kt
Outdated
Show resolved
Hide resolved
...com/google/android/ground/ui/datacollection/tasks/location/CaptureLocationTaskMapFragment.kt
Outdated
Show resolved
Hide resolved
...com/google/android/ground/ui/datacollection/tasks/location/CaptureLocationTaskMapFragment.kt
Outdated
Show resolved
Hide resolved
...src/main/java/com/google/android/ground/ui/datacollection/tasks/point/DropPinTaskFragment.kt
Show resolved
Hide resolved
@gino-m ca we merge this? |
Complete Detail #2761