Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CaptureLocation & DropPin task] Fix crashes on config change #2765

Merged
merged 30 commits into from
Oct 10, 2024
Merged

[CaptureLocation & DropPin task] Fix crashes on config change #2765

merged 30 commits into from
Oct 10, 2024

Commits on Sep 23, 2024

  1. Get view model from parent fragment

    @gino-m
    gino-m committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5160407 View commit details
    Browse the repository at this point in the history

  2. Revert variable rename for cleaner diff

    @gino-m
    gino-m committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    50617df View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into gino-m/2725/fix-task-constructors

    @gino-m
    gino-m authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0e45a5e View commit details
    Browse the repository at this point in the history

  4. Replace uiState with navigationRequests

    @gino-m
    gino-m committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e4b17f3 View commit details
    Browse the repository at this point in the history

  5. Reinit view model on config change

    @gino-m
    gino-m committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8bab435 View commit details
    Browse the repository at this point in the history

  6. Remove debugging log

    @gino-m
    gino-m committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f884dbc View commit details
    Browse the repository at this point in the history

  7. Move arg key into const

    @gino-m
    gino-m committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    731437f View commit details
    Browse the repository at this point in the history

  8. Log error

    @gino-m
    gino-m committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e0201c0 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' of https://github.com/google/ground-android int… 

    …o gino-m/2725/fix-task-constructors
    @gino-m
    gino-m committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    1c05ae8 View commit details
    Browse the repository at this point in the history

  10. Fix failing check

    @gino-m
    gino-m committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d19e353 View commit details
    Browse the repository at this point in the history

  11. Revert changes to manifest

    @gino-m
    gino-m committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0d69e4f View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Fix tests

    @gino-m
    gino-m committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    262c669 View commit details
    Browse the repository at this point in the history

  2. Add TODOs

    @gino-m
    gino-m committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8ba3d92 View commit details
    Browse the repository at this point in the history

  3. Revert formatting change

    @gino-m
    gino-m authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e678e0f View commit details
    Browse the repository at this point in the history

  4. copied same to other map frag

    @anandwana001
    anandwana001 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b908177 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/gino-m/2725/fix-task-constructor… 

    …s' into gino-m/2725/fix-task-constructors
    @anandwana001
    anandwana001 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    24ff226 View commit details
    Browse the repository at this point in the history

  6. viewmodel check

    @anandwana001
    anandwana001 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7d10c42 View commit details
    Browse the repository at this point in the history

  7. Remove final CR

    @gino-m
    gino-m authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    43eed3b View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Remove final CR

    @gino-m
    gino-m authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6cd2594 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. test try

    @anandwana001
    anandwana001 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6446159 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refs/heads/test-fix' into anandwana001/2764/task-config… 

    …-support

# Conflicts:
#	ground/src/main/java/com/google/android/ground/ui/datacollection/tasks/polygon/DrawAreaTaskFragment.kt
    @anandwana001
    anandwana001 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f7848cb View commit details
    Browse the repository at this point in the history

  3. nit fix

    @anandwana001
    anandwana001 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    66b07ac View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/anandwana001/2764/task-config-su… 

    …pport' into anandwana001/2764/task-config-support
    @anandwana001
    anandwana001 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0fb5a68 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Merge branch 'refs/heads/master' into anandwana001/2764/task-config-s… 

    …upport

# Conflicts:
#	ground/src/main/java/com/google/android/ground/ui/datacollection/DataCollectionFragment.kt
#	ground/src/main/java/com/google/android/ground/ui/datacollection/DataCollectionViewPagerAdapter.kt
#	ground/src/main/java/com/google/android/ground/ui/datacollection/tasks/polygon/DrawAreaTaskFragment.kt
#	ground/src/main/java/com/google/android/ground/ui/datacollection/tasks/polygon/DrawAreaTaskMapFragment.kt
#	ground/src/test/java/com/google/android/ground/HiltExt.kt
    @anandwana001
    anandwana001 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    07aed97 View commit details
    Browse the repository at this point in the history

  2. updated

    @anandwana001
    anandwana001 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    436517f View commit details
    Browse the repository at this point in the history

  3. nit fix

    @anandwana001
    anandwana001 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    aec6466 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. moved to base

    @anandwana001
    anandwana001 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    5b8a565 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Merge branch 'master' into anandwana001/2764/task-config-support

    @anandwana001
    anandwana001 authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    300ae1e View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Merge branch 'master' into anandwana001/2764/task-config-support

    @anandwana001
    anandwana001 authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    6ddeeae View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Merge branch 'master' into anandwana001/2764/task-config-support

    @gino-m
    gino-m authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7adfdd1 View commit details
    Browse the repository at this point in the history