Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added null check for Offline LOI #2788

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Merge branch 'master' into anandwana001/2773/offline-loi-check

7819f36
Select commit
Loading
Failed to load commit list.
Open

Added null check for Offline LOI #2788

Merge branch 'master' into anandwana001/2773/offline-loi-check
7819f36
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 4, 2024 in 0s

61.89% (-0.08%) compared to c3ad147

View this Pull Request on Codecov

61.89% (-0.08%) compared to c3ad147

Details

Codecov Report

Attention: Patch coverage is 21.87500% with 25 lines in your changes missing coverage. Please review.

Project coverage is 61.89%. Comparing base (c3ad147) to head (7819f36).

Files with missing lines Patch % Lines
.../android/ground/repository/SubmissionRepository.kt 0.00% 15 Missing ⚠️
.../ground/repository/LocationOfInterestRepository.kt 37.50% 2 Missing and 3 partials ⚠️
...ndroid/ground/ui/syncstatus/SyncStatusViewModel.kt 20.00% 4 Missing ⚠️
...round/ui/datacollection/DataCollectionViewModel.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2788      +/-   ##
============================================
- Coverage     61.96%   61.89%   -0.08%     
  Complexity     1166     1166              
============================================
  Files           265      265              
  Lines          6223     6235      +12     
  Branches        877      883       +6     
============================================
+ Hits           3856     3859       +3     
- Misses         1840     1847       +7     
- Partials        527      529       +2
Files with missing lines Coverage Δ
...round/ui/datacollection/DataCollectionViewModel.kt 71.57% <75.00%> (-0.37%) ⬇️
...ndroid/ground/ui/syncstatus/SyncStatusViewModel.kt 45.45% <20.00%> (-7.18%) ⬇️
.../ground/repository/LocationOfInterestRepository.kt 50.87% <37.50%> (-0.11%) ⬇️
.../android/ground/repository/SubmissionRepository.kt 19.51% <0.00%> (-1.01%) ⬇️
View more details on Codecov