-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added landscape support for Data Collection Dialog #2800
Merged
anandwana001
merged 9 commits into
master
from
anandwana001/2798/landscape-data-collection-dialog
Oct 28, 2024
Merged
Added landscape support for Data Collection Dialog #2800
anandwana001
merged 9 commits into
master
from
anandwana001/2798/landscape-data-collection-dialog
Oct 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gino-m Can you please confirm that the UI elements should be placed in the same order for landscape mode as well? |
@rawbzz wdyt? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2800 +/- ##
============================================
- Coverage 60.75% 60.58% -0.18%
Complexity 1162 1162
============================================
Files 265 265
Lines 6185 6221 +36
Branches 866 878 +12
============================================
+ Hits 3758 3769 +11
- Misses 1937 1950 +13
- Partials 490 502 +12
|
…-collection-dialog' into anandwana001/2798/landscape-data-collection-dialog
...rc/main/java/com/google/android/ground/ui/datacollection/DataSubmissionConfirmationDialog.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/android/ground/ui/datacollection/DataSubmissionConfirmationDialog.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/android/ground/ui/datacollection/DataSubmissionConfirmationDialog.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/android/ground/ui/datacollection/DataSubmissionConfirmationDialog.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/ui/theme/Theme.kt
Outdated
Show resolved
Hide resolved
shobhitagarwal1612
approved these changes
Oct 28, 2024
anandwana001
deleted the
anandwana001/2798/landscape-data-collection-dialog
branch
October 28, 2024 08:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2798
@shobhitagarwal1612 PTAL?