Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added landscape support for Data Collection Dialog #2800

Merged

Conversation

anandwana001
Copy link
Collaborator

@anandwana001 anandwana001 commented Oct 22, 2024

@shobhitagarwal1612
Copy link
Member

@gino-m Can you please confirm that the UI elements should be placed in the same order for landscape mode as well?

@gino-m
Copy link
Collaborator

gino-m commented Oct 22, 2024

@rawbzz wdyt?

@rawbzz
Copy link

rawbzz commented Oct 23, 2024

For dialogs, the text is left aligned and the button is typically on the bottom right side..I wonder if we do something like this and it might scale easier in landscape mode? Let me know what you guys think!Screenshot 2024-10-23 at 11 38 05 AM

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 27 lines in your changes missing coverage. Please review.

Project coverage is 60.58%. Comparing base (502a3bc) to head (054f75b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...datacollection/DataSubmissionConfirmationDialog.kt 52.63% 13 Missing and 14 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2800      +/-   ##
============================================
- Coverage     60.75%   60.58%   -0.18%     
  Complexity     1162     1162              
============================================
  Files           265      265              
  Lines          6185     6221      +36     
  Branches        866      878      +12     
============================================
+ Hits           3758     3769      +11     
- Misses         1937     1950      +13     
- Partials        490      502      +12     
Files with missing lines Coverage Δ
...datacollection/DataSubmissionConfirmationDialog.kt 52.77% <52.63%> (-22.23%) ⬇️

@anandwana001 anandwana001 merged commit 4b19860 into master Oct 28, 2024
4 checks passed
@anandwana001 anandwana001 deleted the anandwana001/2798/landscape-data-collection-dialog branch October 28, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data Collection Dialog - Landscape] Dialog UI is not supporting in Landscape mode
5 participants