fix(volume-rendering): correct data access for histogram in volume rendering with unequal chunk sizes #632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included also in #614 as changes along these lines are needed for that PR.
The histogram computation in volume rendering has been fixed for unequal chunk sizes to both:
In addition, the 3D histogram calculation no longer discards values at exactly 0 after invlerp. The previous behaviour was due to mistaking the above problem with unequal chunk sizes for a different error.