Skip to content

Commit

Permalink
Disable some tests on Windows (#4505)
Browse files Browse the repository at this point in the history
Due to #4502 and #4503, some tests are failing on Windows.
This change disables the effected tests (until a proper fix
is done), such that we can setup the Windows ci.

Test: Build & Run tests
  • Loading branch information
florian-kuebler authored Nov 30, 2022
1 parent 0578f48 commit 68ea644
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
12 changes: 12 additions & 0 deletions src/ObjectUtils/ElfFileTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -595,6 +595,10 @@ TEST(ElfFile, GetDeclarationLocationOfFunction) {
}

TEST(ElfFile, GetDeclarationLocationOfFunctionLibc) {
// TODO(https://github.com/google/orbit/issues/4502): Enable test again.
#ifdef _WIN32
GTEST_SKIP();
#endif
const std::filesystem::path file_path = orbit_test::GetTestdataDir() / "libc.debug";

auto program = CreateElfFile(file_path);
Expand All @@ -611,6 +615,10 @@ TEST(ElfFile, GetDeclarationLocationOfFunctionLibc) {
}

TEST(ElfFile, GetLocationOfFunctionLibc) {
// TODO(https://github.com/google/orbit/issues/4502): Enable test again.
#ifdef _WIN32
GTEST_SKIP();
#endif
const std::filesystem::path file_path = orbit_test::GetTestdataDir() / "libc.debug";

auto program = CreateElfFile(file_path);
Expand All @@ -627,6 +635,10 @@ TEST(ElfFile, GetLocationOfFunctionLibc) {
}

TEST(ElfFile, GetLocationOfFunctionNoSubroutine) {
// TODO(https://github.com/google/orbit/issues/4502): Enable test again.
#ifdef _WIN32
GTEST_SKIP();
#endif
const std::filesystem::path file_path = orbit_test::GetTestdataDir() / "libc.debug";

auto program = CreateElfFile(file_path);
Expand Down
4 changes: 4 additions & 0 deletions src/WindowsUtils/ProcessLauncherTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ TEST(ProcessLauncher, LaunchProcess) {
}

TEST(ProcessLauncher, LaunchSuspendResumeProcess) {
// TODO(https://github.com/google/orbit/issues/4503): Enable test again.
#ifdef _WIN32
GTEST_SKIP();
#endif
ProcessLauncher launcher;
auto launch_result =
launcher.LaunchProcess(GetTestExecutablePath(), /*working_directory=*/"", /*arguments=*/"",
Expand Down

0 comments on commit 68ea644

Please sign in to comment.