Remove temporary type parameters. #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_602078126
branch
from
6e46b33
to
f613a74
Compare
This will break most users who static import both `Truth.assertThat` and `Truth8.assertThat`. The fix is usually as simple as replacing every reference to `Truth8` with a reference to `Truth`. But we'll post some additional migration information as part of the release notes, as we've already done for [1.3.0](https://github.com/google/truth/releases/tag/v1.3.0) and [1.4.0](https://github.com/google/truth/releases/tag/v1.4.0). (The type parameters existed to avoid that static import conflict. However, the type parameters also _cause other static import conflicts_, so we don't want them in place in the long term.) This is one of the remaining loose ends of #746. RELNOTES=Removed temporary type parameters from `Truth.assertThat(Stream)` and `Truth.assertThat(Optional)`. This can create build errors, which you can fix by replacing all your references to `Truth8` with references to `Truth`. PiperOrigin-RevId: 604754613
copybara-service
bot
force-pushed
the
test_602078126
branch
from
f613a74
to
45782bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove temporary type parameters.
This will break most users who static import both
Truth.assertThatandTruth8.assertThat. The fix is usually as simple as replacing every reference toTruth8with a reference toTruth. But we'll post some additional migration information as part of the release notes, as we've already done for 1.3.0 and 1.4.0.(The type parameters existed to avoid that static import conflict. However, the type parameters also cause other static import conflicts, so we don't want them in place in the long term.)
This is one of the remaining loose ends of #746.
RELNOTES=Removed temporary type parameters from
Truth.assertThat(Stream)andTruth.assertThat(Optional). This can create build errors, which you can fix by replacing all your references toTruth8with references toTruth.