-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle multilines in env files #1032
base: main
Are you sure you want to change the base?
Conversation
708c467
to
b0fda39
Compare
4baadb1
to
1de7a33
Compare
src/util.ts
Outdated
const kr = /^[a-zA-Z_]+\w*$/ | ||
const sr = /\s/ | ||
const e: Record<string, string> = {} | ||
let k = '' | ||
let b = '' | ||
let q = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use more readable variable names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minification challenge without any special reason.
(s)pace(r)egex
(k)ey(r)egex
(e)nv
(k)ey
(b)uffer
(q)oute
(i)gnore
(c)har
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make it contributor-friendly and leave minification for Vite plugin!
dotenv requires ~10Kb extra cjs without treeshaking |
I’m against adding support for this feature. |
I'm afraid, it's dotenv format requirement: |
continues #974
fyi, @1e9y , @easymikey